From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCB52C43603 for ; Wed, 4 Dec 2019 10:09:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E0B720675 for ; Wed, 4 Dec 2019 10:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575454163; bh=+vcZT/nr+wvQkboAAcSFVpt9hDwo+WsUeLIrl6pw/Dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jHCAnNq3SZa5AaQjSzrWqNFQMBz9qMCvif9ZWSCK+GEz8GBHvLvTVoLw3TE09/BUB GAZW7ERJlzPvml4z9IDXFcLMv4nqS8ReQPt0gz5yt+l4LoMLFLY3OP2mQDBOXKCePg z4egQg88EnWWOeRcyLo/3tfdgele/Do13SOqX754= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727447AbfLDKJX (ORCPT ); Wed, 4 Dec 2019 05:09:23 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:40760 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfLDKJW (ORCPT ); Wed, 4 Dec 2019 05:09:22 -0500 Received: by mail-wr1-f66.google.com with SMTP id c14so7779502wrn.7; Wed, 04 Dec 2019 02:09:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=raeCtC+dljo0qv32p8D/VuYe95bGrREsFJM19wAQqc8=; b=KNNpisM7QR9D0AXGY6S7UtWvFsgqwnLg/z6E+LyY7Z/PFWc7kGnrlFu6LchmdcXtYB aGFWUf0fW3q2g4j/4SBrKGBNBUhWnrbisCgGNU+O/SwpJUczZTtjNty4T25ydIG98Gu0 9tjFel3etp4TbLMLYVAJvGJ/BCaQguKU3Q3dh1z+kJlCkHV35WqyjNshFNyMS9cS0Ycj 6tjRA7/DKcSkDXS+IXLd/FUf4vTKPti5MP+kI0gqdrTwTDhcsKKQVajzp5h4/DqqfJzf wy5VqBQLFm7a2H9Tj5EmLjZ+SXc0gFVn8MlNI8+nmozpPRfnwMOu53xH3mUvHFM6ToJJ VfOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=raeCtC+dljo0qv32p8D/VuYe95bGrREsFJM19wAQqc8=; b=m9P0nEAY+LH079XRoTxkiUt2k0fxCDFz5WK0DVZhGkNJXI4Ca16HHd2lQqOHv7bc/h Gogdv4WNob5rUcBnVDNQfK1dCEjoL2xpdN6i0OxvOZLJpySCWTdvBLUVtkxkeIi/nvy3 6jjBjKKMoxlE0qpNuh20jy1sj/odrQII2BLmoFqw7IHz2Z4tsH2x88u1h93TjPwth5lT aihHEod4EioxEjPOCpc1D+iqJFHDN1slT126681LeNSavtR+L4QUuRffjfFNtDesqor1 stNvH2WHxOy7t5cBR1oPnPgQj8LJgV+vNLDVT955cJDfzQOh+7BAHOR4S9T1Os+HhvS4 PEXg== X-Gm-Message-State: APjAAAUBrzPK8PwhsW3dtcfYIFxjQQSuXXqRZIi7E30adN+y7c4XEaA8 ILkIsgO6oPQJtEaWCjJxdvZ4weoF X-Google-Smtp-Source: APXvYqx/rwFl+MtYvoLLcqkK+aNtlxTL2ZxgvfhoeTj9iJCmEq1E6xWqdoYOZqa5c48gZrbUu0/hyA== X-Received: by 2002:adf:f78d:: with SMTP id q13mr3059791wrp.365.1575454160662; Wed, 04 Dec 2019 02:09:20 -0800 (PST) Received: from gmail.com (54033286.catv.pool.telekom.hu. [84.3.50.134]) by smtp.gmail.com with ESMTPSA id h17sm7904846wrs.18.2019.12.04.02.09.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 02:09:19 -0800 (PST) Date: Wed, 4 Dec 2019 11:09:17 +0100 From: Ingo Molnar To: Dave Young Cc: linux-efi@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Michael Weiser , Ard Biesheuvel , kexec@lists.infradead.org, Ingo Molnar , Borislav Petkov , "Eric W. Biederman" , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH] x86/efi: update e820 about reserved EFI boot services data to fix kexec breakage Message-ID: <20191204100917.GC114697@gmail.com> References: <20191204075233.GA10520@dhcp-128-65.nay.redhat.com> <20191204075917.GA10587@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204075917.GA10587@dhcp-128-65.nay.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org * Dave Young wrote: > On 12/04/19 at 03:52pm, Dave Young wrote: > > Michael Weiser reported he got below error during a kexec rebooting: > > esrt: Unsupported ESRT version 2904149718861218184. > > > > The ESRT memory stays in EFI boot services data, and it was reserved > > in kernel via efi_mem_reserve(). The initial purpose of the reservation > > is to reuse the EFI boot services data across kexec reboot. For example > > the BGRT image data and some ESRT memory like Michael reported. > > > > But although the memory is reserved it is not updated in X86 e820 table. > > And kexec_file_load iterate system ram in io resource list to find places > > for kernel, initramfs and other stuff. In Michael's case the kexec loaded > > initramfs overwritten the ESRT memory and then the failure happened. > > s/overwritten/overwrote :) If need a repost please let me know.. No need, I've edited the typo. :) Thanks, Ingo