Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Masayoshi Mizuma <msys.mizuma@gmail.com>
To: James Morse <james.morse@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	linux-efi@vger.kernel.org, mark.rutland@arm.com,
	Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>,
	d.hatayama@fujitsu.com, kexec@lists.infradead.org
Subject: Re: [PATCH] efi/memreserve: register reservations as 'reserved' in /proc/iomem
Date: Wed, 4 Dec 2019 13:57:08 -0500
Message-ID: <20191204185708.hdoa5gzmfr547q53@gabell> (raw)
In-Reply-To: <08f05b18-12b2-0ba4-b819-b95ba27d1862@arm.com>

On Wed, Dec 04, 2019 at 06:17:59PM +0000, James Morse wrote:
> Hi Masa,
> 
> On 04/12/2019 17:17, Masayoshi Mizuma wrote:
> > Thank you for sending the patch, but unfortunately it doesn't work for the issue...
> > 
> > After applied your patch, the LPI tables are marked as reserved in
> > /proc/iomem like as:
> > 
> > 80300000-a1fdffff : System RAM
> >   80480000-8134ffff : Kernel code
> >   81350000-817bffff : reserved
> >   817c0000-82acffff : Kernel data
> >   830f0000-830fffff : reserved # Property table
> >   83480000-83480fff : reserved # Pending table
> >   83490000-8349ffff : reserved # Pending table
> > 
> > However, kexec tries to allocate memory from System RAM, it doesn't care
> > the reserved in System RAM.
> 
> > I'm not sure why kexec doesn't care the reserved in System RAM, however,
> 
> Hmm, we added these to fix a problem with the UEFI memory map, and more recently ACPI
> tables being overwritten by kexec.
> 
> Which version of kexec-tools are you using? Could you try:
> https://git.linaro.org/people/takahiro.akashi/kexec-tools.git/commit/?h=arm64/resv_mem

Thanks a lot! It worked and the issue is gone with Ard's patch and
the linaro kexec (arm64/resv_mem branch).

Ard, please feel free to add:

	Tested-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>

> 
> 
> > if the kexec behaivor is right, the LPI tables should not belong to
> > System RAM.
> 
> > Like as:
> > 
> > 80300000-830effff : System RAM
> >   80480000-8134ffff : Kernel code
> >   81350000-817bffff : reserved
> >   817c0000-82acffff : Kernel data
> > 830f0000-830fffff : reserved # Property table
> > 83480000-83480fff : reserved # Pending table
> > 83490000-8349ffff : reserved # Pending table
> > 834a0000-a1fdffff : System RAM
> > 
> > I don't have ideas to separete LPI tables from System RAM... so I tried
> > to add a new file to inform the LPI tables to userspace.
> 
> This is how 'nomap' memory appears, we carve it out of System RAM. A side effect of this
> is kdump can't touch it, as you've told it this isn't memory.
> 
> As these tables are memory, mapped by the linear map, I think Ard's patch is the right
> thing to do ... I suspect your kexec-tools doesn't have those patches from Akashi to make
> it honour all second level entries.
 
I used the kexec on the top of master branch:
git://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git

Should we use the linaro kexec for aarch64 machine?
Or will the arm64/resv_mem branch be merged to the kexec on
git.kernel.org...?

Thanks!
Masa

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 14:52 Ard Biesheuvel
2019-12-04 17:17 ` Masayoshi Mizuma
2019-12-04 18:17   ` James Morse
2019-12-04 18:57     ` Masayoshi Mizuma [this message]
2019-12-04 20:13       ` Bhupesh SHARMA
2019-12-05  9:28         ` Ard Biesheuvel

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204185708.hdoa5gzmfr547q53@gabell \
    --to=msys.mizuma@gmail.com \
    --cc=ardb@kernel.org \
    --cc=d.hatayama@fujitsu.com \
    --cc=james.morse@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=m.mizuma@jp.fujitsu.com \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git