From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6819FC2D0C2 for ; Thu, 2 Jan 2020 18:10:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B317206E6 for ; Thu, 2 Jan 2020 18:10:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MEXYZrv8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727984AbgABSKT (ORCPT ); Thu, 2 Jan 2020 13:10:19 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:37308 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbgABSKS (ORCPT ); Thu, 2 Jan 2020 13:10:18 -0500 Received: by mail-qt1-f196.google.com with SMTP id w47so35236734qtk.4 for ; Thu, 02 Jan 2020 10:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WWcH4/7sry9WUFtHJqusPNxo12okI1+y3DAmxoC8oXs=; b=MEXYZrv8jijjGETUTGNahjg5y1Xiry0D+ZvT3+0NR8tEf86pY2kMv289+LNzTqgXM/ HgWSREll+qA16/dUtHEFkz5D+fSQYaPpzOWNi+4Jjdv3smPu8J9uuqOyQ0nLgS7DkrZ0 BP6BoBf/7Xo7wPLqMTVhpip6NLKpjEE0PSZeVhRVCLAbRqgFGLRWYu0/vz7Nh3xs9zlm FDzP+6nQ6T7ROgNVS90Zd0b2qHNivDZgnVezxVxU2Wiawje8dIH0TPCjJgJ1On7M6ZAy ak1uHjBKZCgaLe+kd6FkYv7SZG+t6Q2/JuCwPlKcNm5yr4XVXfJnv+jlQQEVCZza4YAi kREw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=WWcH4/7sry9WUFtHJqusPNxo12okI1+y3DAmxoC8oXs=; b=S3VqPVCvahs0c4reRE7V9FvLX08nkeRQECiJ2QT5/czjiymryScctAOTertc2zzPP0 1jbVsrHIpi5u6iIELK2P5OLGI7AH+mBI3Lwd3FR+TQgbwhmcZfvid+h35GUWK0mlMylp jLqWBYvK0eOQzB3N/3GGVz+ckHtYpeeCPEGCa3oJr78z4NEcf5KkBpii/2RLbIqUU9bk MQc9vbxh+gsaOYs96Y8LJxXjsrLoBS/VYnERe095lSMCnl/o2hiNkhcrRfiI9WFiO035 p5cKATRYGK/V37wB/BdS/mKER+M74bTaFqthdThfjlv1gGi4C9QnFX6SKsIqo5kDlfos MUYA== X-Gm-Message-State: APjAAAU6Y8TcTEEgXWrUakueOJ3SGEIeYdhCR7BYMWxWPnHuKrapRo1V bDhaWwq/gfLLgMBEyo76wK0= X-Google-Smtp-Source: APXvYqz1ftM8AY3llHJewdasEen6Q8ANZ5jDGuwXqioUYrZA05oARGGY2jXnLxtJ4yg4vrGKsnh5CA== X-Received: by 2002:ac8:31f0:: with SMTP id i45mr61469640qte.327.1577988617772; Thu, 02 Jan 2020 10:10:17 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id c24sm14854050qtk.40.2020.01.02.10.10.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jan 2020 10:10:17 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Thu, 2 Jan 2020 13:10:15 -0500 To: Ard Biesheuvel Cc: Arvind Sankar , Ard Biesheuvel , linux-efi , Hans de Goede , Matthew Garrett , Ingo Molnar , Andy Lutomirski , Thomas Gleixner Subject: Re: [PATCH v2 13/21] efi/libstub/x86: drop __efi_early() export of efi_config struct Message-ID: <20200102181015.GA720259@rani.riverdale.lan> References: <20200102140653.GA626673@rani.riverdale.lan> <20200102155129.GA668939@rani.riverdale.lan> <20200102172637.GB701372@rani.riverdale.lan> <20200102174142.GA713602@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Thu, Jan 02, 2020 at 06:48:52PM +0100, Ard Biesheuvel wrote: > Currently, I am not managing to get the 64-bit compiler to emit any > GOT based references for efi_is64, though, even without the attribute, > so I am not sure what's going on there. With gcc 9, I do get R_X86_64_REX_GOTPCRELX relocations in libstub, which are then eliminated by the linker -- if they weren't they would be using addresses from the GOT. They turn into R_X86_64_PC32 with the hidden visibility.