From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62EDC2BA83 for ; Thu, 13 Feb 2020 10:21:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7C4D24650 for ; Thu, 13 Feb 2020 10:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581589271; bh=Kyl8I1DFqEKINSEj7nz5tEXZ5ssSBEs7mkX+qP/eNKg=; h=From:To:Cc:Subject:Date:List-ID:From; b=JwBPQOjDglI8rn/fMyRHQNbTxcOTX0OxX1Ch1Bo2yz2ESHjUbEyQuHsKuMwwz79a0 64gRGf6O17Ax055zznmvqyXJjCQ0ijRPF+Bm9vecPdkup7b96NhOt7R4Od3rDbgW5i 7st6YdfHde+gHCMsVT1yYyuGycaKNh4yG8597dhE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729494AbgBMKVL (ORCPT ); Thu, 13 Feb 2020 05:21:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:54106 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729428AbgBMKVL (ORCPT ); Thu, 13 Feb 2020 05:21:11 -0500 Received: from cam-smtp0.cambridge.arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08AAC217F4; Thu, 13 Feb 2020 10:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581589270; bh=Kyl8I1DFqEKINSEj7nz5tEXZ5ssSBEs7mkX+qP/eNKg=; h=From:To:Cc:Subject:Date:From; b=ivSIR+QRZBwcdxwxZOl2Bq7e6z64WpepSQmFSCShK1DeBeoMT2XZWy5WatUxmDS54 pOB/JgxMaT6Esl00QCBZ5VbSpBQpRLnJ+9jkc717OdmHjSVqUov3DwQocUKWRsemjD Z85oin0naN9DQKpNMzl+NoQoE+qxZPewIOtF/1nc= From: Ard Biesheuvel To: linux-efi@vger.kernel.org Cc: Ard Biesheuvel , Hans de Goede , Arvind Sankar , Andy Lutomirski Subject: [PATCH 0/3] efi/x86: Some mixed mode fixes Date: Thu, 13 Feb 2020 11:20:59 +0100 Message-Id: <20200213102102.30170-1-ardb@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Hans reports that v5.6-rc1 triggers a WARN() when booting in mixed mode, which appears to be due to the fact that a GUID argument allocated on the vmap'ed stack and passed by reference to the EFI runtime services is no longer aligned to its size, which is what the mixed mode runtime wrappers expect. Let's fix this in a way that doesn't burden the caller, and copy the GUID into a suitably aligned buffer in the runtime wrappers. (#1) Then, patches #2 and #3 are additional cleanup and correctness fixes for the mixed mode runtime wrappers. Cc: Hans de Goede Cc: Arvind Sankar Cc: Andy Lutomirski Ard Biesheuvel (3): efi/x86: align GUIDs to their size in the mixed mode runtime wrapper efi/x86: remove support for EFI time and counter services in mixed mode efi/x86: Handle by-ref arguments covering multiple pages in mixed mode arch/x86/platform/efi/efi_64.c | 151 +++++++------------- 1 file changed, 52 insertions(+), 99 deletions(-) -- 2.17.1