From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373E4C3F2CD for ; Sun, 1 Mar 2020 20:00:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE2F3246C0 for ; Sun, 1 Mar 2020 20:00:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mq6ppiWh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725945AbgCAUAi (ORCPT ); Sun, 1 Mar 2020 15:00:38 -0500 Received: from mail-qt1-f194.google.com ([209.85.160.194]:45302 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725895AbgCAUAi (ORCPT ); Sun, 1 Mar 2020 15:00:38 -0500 Received: by mail-qt1-f194.google.com with SMTP id a4so12312qto.12 for ; Sun, 01 Mar 2020 12:00:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=c+F+wlqGzMoVE2eRUr2Al/MVfpWMoI3CqyWecCvq+rc=; b=mq6ppiWh/ehsQcH5CDYy/yjUGd13ahaeKMMeKwEl6kvqB35fuJglBnaYmsk8csmSqC 3Ier2KmLxFwACI0f9FpBLhP13QN1xjjigagXCbfdoTga7Rblr5EXf8dhU3JKk5rV7XND ITb7BxmNybUMFUyB+Y4acJGtmkn6ANUHXHDA5Xvl/prYSR7fUUDsEDxQiW2auVNEI45d 4nw671ZpHL1JnVbQzQ4sjFMtxcXYq4tf9RsQDJ5LkZZAEQGDQoRe9HY6LWCk6OOifoh8 TCccfvDttXRJYm5I2Rn8Z7l0c+7erVrf0z2RaLTGoGBMER4P/zxn3kVq2fmKLtT0QQ3X sprA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=c+F+wlqGzMoVE2eRUr2Al/MVfpWMoI3CqyWecCvq+rc=; b=qx/JuewGLmk06oxk21y6YIfWG785ImoW+0QzHB16W9Zn6LfMvH8a/cVSZLKhW1lP3F tc4LBWi6Iw6e2JXuFi384SLbpq+2fpFxyksyfaoEI6lVJ3m/2V0lUNdD4pg+mou8Vv5h xq26ekETicJyQLiT7ozAj1MbFDIO/b1mg7ARwsw88KzeJZAEJDaKMFdl0g6F5rX2IrWH C6TIKkqPDiNdY+WtF4P00hz4TKOseSsCOLH67hIE4eihzDoMneD8Te/9FOfWUuv9ZFih zT0II/blNDWbkJVRWHdB36jqRrImBtJFXNRwZ/IcWRf8da7KBkt0LUgZB1SWTk+NUIc3 U+vg== X-Gm-Message-State: APjAAAXFSKL/T4c2Mkic0/Sif8KkI/19ggY9LuYYEVHq825eQb9fhvKi Fs89r80H21Rg4dY9ZtpqUWRJz/KeS5Y= X-Google-Smtp-Source: APXvYqzRgd3GOfks8DF8S5dd8vtyyAcVmOyvdQSvMLo0PNRgSpAmZlUT/nUxoy+Zgmgx9ijgmIAcXQ== X-Received: by 2002:ac8:4a16:: with SMTP id x22mr12925904qtq.339.1583092837364; Sun, 01 Mar 2020 12:00:37 -0800 (PST) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id 11sm8679959qko.76.2020.03.01.12.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Mar 2020 12:00:37 -0800 (PST) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Sun, 1 Mar 2020 15:00:35 -0500 To: Ard Biesheuvel Cc: Arvind Sankar , linux-efi , Hans de Goede , the arch/x86 maintainers Subject: Re: [PATCH v3 0/6] efi/x86: add support for generic EFI mixed mode boot Message-ID: <20200301200035.GA2031375@rani.riverdale.lan> References: <20200222155519.23550-1-ardb@kernel.org> <20200301171509.GA1845222@rani.riverdale.lan> <20200301172248.GA1851857@rani.riverdale.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Sun, Mar 01, 2020 at 08:36:42PM +0100, Ard Biesheuvel wrote: > On Sun, 1 Mar 2020 at 18:22, Arvind Sankar wrote: > > > > On Sun, Mar 01, 2020 at 12:15:10PM -0500, Arvind Sankar wrote: > > > What I'm doing is creating an x86-64 defconfig based on tip:efi/core, > > > and then running it via > > > > > > $ qemu-system-x86_64 -cpu Haswell -pflash qemu/OVMF_64.fd \ > > ^^^^^^^ > > That OVMF_64.fd is incorrect copy/paste from a different run, the panic > > case is using OVMF-mixed-mode-compat-section.fd. > > > -drive file=fat:rw:qemu/boot -nographic -m 3072 > > Thanks for the patch. Interestingly, I don't even make it to the point > where it crashes, and I end up in an ASSERT() in the firmware: > > ASSERT_EFI_ERROR (Status = Not Found) > ASSERT /home/ardbie01/build/edk2/MdeModulePkg/Universal/ReportStatusCodeRouter/RuntimeDxe/ReportStatusCodeRouterRuntimeDxe.c(347): > !EFI_ERROR (Status) > > which appears to be a result of the fact that the memory map passed to > SetVirtualAddressMap() does not cover some function pointer that gets > converted in that code. > > I don't remember - does mixed mode even work in general with 3 GB of memory? Oh -- is there some option to enable debugging assertions? I did see that it crashed somewhere inside SetVirtualMap (i.e. we called it and it never returned). For some reason, with nokaslr on the command line, I can't get this to crash. All the addresses seem to be within 4Gb, so it ought to work, no?