From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88998C4332B for ; Fri, 20 Mar 2020 13:54:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E88220722 for ; Fri, 20 Mar 2020 13:54:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="F0FOPtBw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgCTNyc (ORCPT ); Fri, 20 Mar 2020 09:54:32 -0400 Received: from mail.skyhub.de ([5.9.137.197]:37678 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726773AbgCTNyb (ORCPT ); Fri, 20 Mar 2020 09:54:31 -0400 Received: from zn.tnic (p200300EC2F0A5A004DAD0A631927B72B.dip0.t-ipconnect.de [IPv6:2003:ec:2f0a:5a00:4dad:a63:1927:b72b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 67BE21EC0CF9; Fri, 20 Mar 2020 14:54:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1584712470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4kRlOKjHakNgyDMJ+wwWO6fJ9qGChnt/waqHmA/UUGY=; b=F0FOPtBwjQP0paqttkINRGbxEcmOMVhN4oL0yj58aGG1avkm9QONlkR8NBXjqQSmqDIw9L vxUZqNovMOIpqMvYdssliy14K12ktEZxIEt77Wsy46H0CUd3oWK+NCFRLHn2wB6zcdZ5JU D0uVIwOLBo4Llp8mhOb2XsweNN/eGPw= Date: Fri, 20 Mar 2020 14:54:36 +0100 From: Borislav Petkov To: Daniel Drake Cc: Jian-Hong Pan , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , x86@kernel.org, Linux Kernel , linux-efi@vger.kernel.org, Linux Upstreaming Team Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T" Message-ID: <20200320135436.GA23532@zn.tnic> References: <20200312083341.9365-1-jian-hong@endlessm.com> <20200312104643.GA15619@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, Mar 20, 2020 at 08:37:54PM +0800, Daniel Drake wrote: > Based on that I was considering that the patch could be reverted for > cleanliness/ At the same time, I do not have strong feelings on this, > no issues if the quirk is left in place. Oh, I'd take the revert on cleanliness grounds any day of the week. But if that broken fw has snuck out and someone comes and complains that it wouldn't reboot properly, then I'd have to revert the revert. And looking at that reboot_dmi_table[] of who's who of broken BIOSes, one entry less ain't gonna make it prettier. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette