From: Borislav Petkov <bp@alien8.de>
To: Ard Biesheuvel <ardb@kernel.org>, Arvind Sankar <nivedita@alum.mit.edu>
Cc: Sergey Shatunov <me@prok.pw>,
hpa@zytor.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mingo@redhat.com, Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, linux-efi <linux-efi@vger.kernel.org>,
initramfs@vger.kernel.org,
Donovan Tremura <neurognostic@protonmail.ch>,
Harald Hoyer <harald@hoyer.xyz>
Subject: Re: [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage
Date: Mon, 6 Apr 2020 19:21:02 +0200 [thread overview]
Message-ID: <20200406172102.GF2520@zn.tnic> (raw)
In-Reply-To: <CAMj1kXG+34-bK1XuxX5VopkRt1SV1ewUAEmif+aQj5cJQ=9vbA@mail.gmail.com>
On Mon, Apr 06, 2020 at 03:29:18PM +0200, Ard Biesheuvel wrote:
> > What do you think of the other problem -- that's actually worse to fix,
> > as it won't just be when kaslr is disabled, the startup_64 code will do
> > relocation to the end of init_size and clobber the initrd before getting
> > to the kaslr code, so it will break as soon as the firmware loads the
> > "unified kernel image" at a 2Mb-aligned address. The only thing I can
> > think of is to just unconditionally call efi_relocate_kernel if we were
> > entered via handover_entry?
> >
>
> Yes, that seems to be the most robust approach.
The commit in question is this one:
d5cdf4cfeac9 ("efi/x86: Don't relocate the kernel unless necessary")
I presume?
I'm guessing it can simply be reverted as it doesn't fix a bug but it is
just an optimization... provided I'm not missing something, of course.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-04-06 17:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200109150218.16544-1-nivedita@alum.mit.edu>
[not found] ` <20200405154245.11972-1-me@prok.pw>
2020-04-05 23:18 ` [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Arvind Sankar
2020-04-06 0:00 ` Sergey Shatunov
2020-04-06 3:51 ` Arvind Sankar
2020-04-06 7:32 ` Ard Biesheuvel
2020-04-06 8:47 ` Borislav Petkov
2020-04-06 9:11 ` Ard Biesheuvel
2020-04-06 11:20 ` Borislav Petkov
2020-04-06 13:22 ` Arvind Sankar
2020-04-06 13:29 ` Ard Biesheuvel
2020-04-06 16:01 ` Arvind Sankar
2020-04-06 16:22 ` Ard Biesheuvel
2020-04-06 16:52 ` Arvind Sankar
2020-04-06 16:59 ` Ard Biesheuvel
2020-04-06 18:06 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Arvind Sankar
2020-04-06 18:06 ` [PATCH 2/2] efi/x86: Always relocate the kernel for EFI handover entry Arvind Sankar
2020-04-06 18:29 ` [PATCH 1/2] efi/x86: Move efi stub globals from .bss to .data Ard Biesheuvel
2020-04-08 7:43 ` Dave Young
2020-04-08 7:49 ` Ard Biesheuvel
2020-04-09 14:39 ` Arvind Sankar
2020-04-09 14:47 ` Ard Biesheuvel
2020-04-09 16:35 ` Arvind Sankar
2020-04-10 14:47 ` Arvind Sankar
2020-04-10 15:26 ` Ard Biesheuvel
2020-04-14 14:57 ` Daniel Kiper
2020-04-10 11:26 ` Thomas Meyer
2020-04-10 14:38 ` Arvind Sankar
2020-04-11 8:50 ` Thomas Meyer
2020-04-06 17:21 ` Borislav Petkov [this message]
2020-04-06 8:44 ` [PATCH 1/2] x86/boot/compressed/64: Remove .bss/.pgtable from bzImage Ard Biesheuvel
2020-04-06 12:36 ` Sergey Shatunov
2020-04-06 13:20 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406172102.GF2520@zn.tnic \
--to=bp@alien8.de \
--cc=ardb@kernel.org \
--cc=harald@hoyer.xyz \
--cc=hpa@zytor.com \
--cc=initramfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@prok.pw \
--cc=mingo@redhat.com \
--cc=neurognostic@protonmail.ch \
--cc=nivedita@alum.mit.edu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).