From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFFCDC83000 for ; Tue, 28 Apr 2020 15:11:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0BB3206D8 for ; Tue, 28 Apr 2020 15:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588086690; bh=aamxra8/L8gjllOiveVDPAUmrn8wwP+GQF0Iq8KS/QI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=06uRrT1G/TLfX/Ilo2jPIJ6lAqMgNwOjaxpSElxupZBuDb8yKwSVe3dWUneQAkwkt rAJ+UqcYKBb2GAgASExpRaIQZRiMk+xEK/FsAYz3m27GcStcBN4IdHXDZgXgHIOAYw C/PmNMibGcAKJzMRtZSqxkm55W+f069pa2VYYXrk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727915AbgD1PLa (ORCPT ); Tue, 28 Apr 2020 11:11:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:59698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727860AbgD1PLa (ORCPT ); Tue, 28 Apr 2020 11:11:30 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95B6D205C9; Tue, 28 Apr 2020 15:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588086689; bh=aamxra8/L8gjllOiveVDPAUmrn8wwP+GQF0Iq8KS/QI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jpiRez2WIvdzuInq82Nf0S3PYv5YCwZqKrjdv4MQBiyq+3u9y8W2hoKAgxgVlFhJo AIk4vnsqN+dwq5AOhKZVvfs0Muvx8BvsscxPjCua0GhClnTEC2uAJc/BBnbKJIb7/L nv8pJ8p4peMND1YYHAKBL3M+9Mnl/X9mt028uGac= Date: Tue, 28 Apr 2020 16:11:25 +0100 From: Will Deacon To: Ard Biesheuvel Cc: linux-efi , Linux ARM , Mark Rutland , Catalin Marinas , Jonathan Cameron , Arvind Sankar Subject: Re: [PATCH v2 5/8] efi/libstub/arm64: align PE/COFF sections to segment alignment Message-ID: <20200428151123.GA12697@willie-the-truck> References: <20200413155521.24698-1-ardb@kernel.org> <20200413155521.24698-6-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, Apr 22, 2020 at 11:39:39AM +0200, Ard Biesheuvel wrote: > On Mon, 13 Apr 2020 at 17:55, Ard Biesheuvel wrote: > > > > The arm64 kernel's segment alignment is fixed at 64 KB for any page > > size, and relocatable kernels are able to fix up any misalignment of > > the kernel image with respect to the 2 MB section alignment that is > > mandated by the arm64 boot protocol. > > > > Let's increase the PE/COFF section alignment to the same value, so that > > kernels loaded by the UEFI PE/COFF loader are guaranteed to end up at > > an address that doesn't require any reallocation to be done if the > > kernel is relocatable. > > > > Signed-off-by: Ard Biesheuvel > > --- > > arch/arm64/kernel/efi-header.S | 2 +- > > arch/arm64/kernel/vmlinux.lds.S | 3 ++- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > > > Catalin, Will: any thoughts whether this should go via the arm64 tree > or the EFI tree? It is part of a change on the EFI side to stop > needlessly copying the kernel around before boot, but this particular > change could go through either tree, as it is not build time > dependency for the EFI changes, nor does it have a boot time impact > beyond making it more likely that the copy can be elided (but the code > still needs to deal with the possibility that it cannot be elided in > any case) I've queued this one in the arm64 tree for 5.8. Should appear on for-next/misc in the next day or so. Thanks, Will