From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tyler Hicks <tyhicks@linux.microsoft.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
Matthew Garrett <mjg59@google.com>,
Peter Jones <pjones@redhat.com>, Peter Huewe <peterhuewe@gmx.de>,
Jason Gunthorpe <jgg@ziepe.ca>, Petr Vandrovec <petr@vmware.com>,
Nayna Jain <nayna@linux.ibm.com>,
Thirupathaiah Annapureddy <thiruan@microsoft.com>,
linux-integrity <linux-integrity@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures
Date: Fri, 10 Jul 2020 14:02:07 +0300 [thread overview]
Message-ID: <20200710110207.GC2614@linux.intel.com> (raw)
In-Reply-To: <20200709225823.GA4939@sequoia>
On Thu, Jul 09, 2020 at 05:58:23PM -0500, Tyler Hicks wrote:
> On 2020-07-03 02:57:18, Jarkko Sakkinen wrote:
> > On Tue, Jun 30, 2020 at 01:33:21PM -0500, Tyler Hicks wrote:
> > > Jarkko, is this an ack from you?
> > >
> > > Is there anything I can do to help along this fix?
> > >
> > > I've spoke with two others that have poured through these specs to
> > > implement firmware event log parsers and they thought the change made
> > > sense.
> > >
> > > Tyler
> >
> > I revisited the original patch and this stroke into my eye:
> >
> > "This is true, for example, when firmware passes the event log to the
> > kernel via a reserved memory region described in device tree."
> >
> > During this discussion you gave an explanation what can trigger the bug
> > but in the commit message nothing anchors to anything.
> >
> > Please give a concrete example what can trigger the issue directly in
> > the commit message instead. It's obviously needed.
> >
> > In addition, you could also rewrite the existing inline comment to be
> > something more reasonable to the context.
>
> These are all fair points and I also see that there's a new conflict
> with the TPM next branch. I'll rebase the patch on the current next
> branch, expand on the commit message, and improve the comment in v2.
>
> Tyler
Thank you.
/Jarkko
next prev parent reply other threads:[~2020-07-10 11:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 23:25 [PATCH] tpm: Require that all digests are present in TCG_PCR_EVENT2 structures Tyler Hicks
2020-06-16 9:08 ` Ard Biesheuvel
2020-06-16 15:22 ` Tyler Hicks
2020-06-17 23:09 ` Jarkko Sakkinen
2020-06-30 18:33 ` Tyler Hicks
2020-07-02 23:57 ` Jarkko Sakkinen
2020-07-09 22:58 ` Tyler Hicks
2020-07-10 11:02 ` Jarkko Sakkinen [this message]
2020-06-30 18:53 ` Peter Jones
2020-06-30 19:10 ` Ard Biesheuvel
2020-06-30 19:23 ` Tyler Hicks
2020-06-30 19:48 ` Peter Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710110207.GC2614@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ardb@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-efi@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@google.com \
--cc=nayna@linux.ibm.com \
--cc=peterhuewe@gmx.de \
--cc=petr@vmware.com \
--cc=pjones@redhat.com \
--cc=thiruan@microsoft.com \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).