linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: dann frazier <dann.frazier@canonical.com>
Cc: stable@vger.kernel.org, Michael Schaller <misch@google.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Jeremy Kerr <jk@ozlabs.org>,
	linux-efi@vger.kernel.org
Subject: Re: [PATCH 4.4-5.9] efivarfs: Replace invalid slashes with exclamation marks in dentries.
Date: Thu, 29 Oct 2020 20:19:23 +0100	[thread overview]
Message-ID: <20201029191923.GB988039@kroah.com> (raw)
In-Reply-To: <20201029175442.564282-1-dann.frazier@canonical.com>

On Thu, Oct 29, 2020 at 11:54:42AM -0600, dann frazier wrote:
> From: Michael Schaller <misch@google.com>
> 
> commit 336af6a4686d885a067ecea8c3c3dd129ba4fc75 upstream
> 
> Without this patch efivarfs_alloc_dentry creates dentries with slashes in
> their name if the respective EFI variable has slashes in its name. This in
> turn causes EIO on getdents64, which prevents a complete directory listing
> of /sys/firmware/efi/efivars/.
> 
> This patch replaces the invalid shlashes with exclamation marks like
> kobject_set_name_vargs does for /sys/firmware/efi/vars/ to have consistently
> named dentries under /sys/firmware/efi/vars/ and /sys/firmware/efi/efivars/.
> 
> Signed-off-by: Michael Schaller <misch@google.com>
> Link: https://lore.kernel.org/r/20200925074502.150448-1-misch@google.com
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

Any reason you are not signing off on this?

:(


  reply	other threads:[~2020-10-29 19:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 17:54 [PATCH 4.4-5.9] efivarfs: Replace invalid slashes with exclamation marks in dentries dann frazier
2020-10-29 19:19 ` Greg KH [this message]
2020-10-29 19:20   ` dann frazier
2020-10-29 19:28     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029191923.GB988039@kroah.com \
    --to=greg@kroah.com \
    --cc=ardb@kernel.org \
    --cc=dann.frazier@canonical.com \
    --cc=jk@ozlabs.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=misch@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).