From: Catalin Marinas <catalin.marinas@arm.com>
To: Michael Kelley <mikelley@microsoft.com>
Cc: will@kernel.org, mark.rutland@arm.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
linux-efi@vger.kernel.org, wei.liu@kernel.org, kys@microsoft.com,
sthemmin@microsoft.com, ardb@kernel.org
Subject: Re: [PATCH v12 0/5] Enable Linux guests on Hyper-V on ARM64
Date: Wed, 4 Aug 2021 17:25:57 +0100 [thread overview]
Message-ID: <20210804162555.GD4857@arm.com> (raw)
In-Reply-To: <1628092359-61351-1-git-send-email-mikelley@microsoft.com>
On Wed, Aug 04, 2021 at 08:52:34AM -0700, Michael Kelley wrote:
> This series enables Linux guests running on Hyper-V on ARM64
> hardware. New ARM64-specific code in arch/arm64/hyperv initializes
> Hyper-V and its hypercall mechanism. Existing architecture
> independent drivers for Hyper-V's VMbus and synthetic devices just
> work when built for ARM64. Hyper-V code is built and included in
> the image and modules only if CONFIG_HYPERV is enabled.
[...]
> Hyper-V on ARM64 runs with a 4 Kbyte page size, but allows guests
> with 4K/16K/64K page size. Linux guests with this patch series
> work with all three supported ARM64 page sizes.
>
> The Hyper-V vPCI driver at drivers/pci/host/pci-hyperv.c has
> x86/x64-specific code and is not being built for ARM64. Enabling
> Hyper-V vPCI devices on ARM64 is in progress via a separate set
> of patches.
>
> This patch set is based on the linux-next20210720 code tree.
Is it possible to rebase this on top of -rc3? Are there any
dependencies or do you plan to upstream this via a different tree?
It applies cleanly but it doesn't build for me:
In file included from arch/arm64/include/asm/mshyperv.h:52,
from arch/arm64/hyperv/hv_core.c:19:
include/asm-generic/mshyperv.h: In function 'hv_do_rep_hypercall':
include/asm-generic/mshyperv.h:86:3: error: implicit declaration of function 'touch_nmi_watchdog' [-Werror=implicit-function-declaration]
86 | touch_nmi_watchdog();
| ^~~~~~~~~~~~~~~~~~
A quick fix for the above was to include nmi.h in mshyperv.h.
However, the below I can't fix since there's no trace of
hv_common_init() on top of 5.14-rc3:
arch/arm64/hyperv/mshyperv.c: In function 'hyperv_init':
arch/arm64/hyperv/mshyperv.c:66:8: error: implicit declaration of function 'hv_common_init' [-Werror=implicit-function-declaration]
66 | ret = hv_common_init();
| ^~~~~~~~~~~~~~
arch/arm64/hyperv/mshyperv.c:71:5: error: 'hv_common_cpu_init' undeclared (first use in this function)
71 | hv_common_cpu_init, hv_common_cpu_die);
| ^~~~~~~~~~~~~~~~~~
arch/arm64/hyperv/mshyperv.c:71:5: note: each undeclared identifier is reported only once for each function it appears in
arch/arm64/hyperv/mshyperv.c:71:25: error: 'hv_common_cpu_die' undeclared (first use in this function)
71 | hv_common_cpu_init, hv_common_cpu_die);
| ^~~~~~~~~~~~~~~~~
arch/arm64/hyperv/mshyperv.c:73:3: error: implicit declaration of function 'hv_common_free' [-Werror=implicit-function-declaration]
73 | hv_common_free();
| ^~~~~~~~~~~~~~
--
Catalin
next prev parent reply other threads:[~2021-08-04 16:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 15:52 [PATCH v12 0/5] Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2021-08-04 15:52 ` [PATCH v12 1/5] arm64: hyperv: Add Hyper-V hypercall and register access utilities Michael Kelley
2021-08-04 15:52 ` [PATCH v12 2/5] arm64: hyperv: Add panic handler Michael Kelley
2021-08-04 15:52 ` [PATCH v12 3/5] arm64: hyperv: Initialize hypervisor on boot Michael Kelley
2021-08-04 15:52 ` [PATCH v12 4/5] arm64: efi: Export screen_info Michael Kelley
2021-08-04 15:52 ` [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Michael Kelley
2021-08-04 16:10 ` Catalin Marinas
2021-08-04 16:40 ` Wei Liu
2021-08-04 16:43 ` Michael Kelley
2021-08-04 16:25 ` Catalin Marinas [this message]
2021-08-04 16:37 ` [PATCH v12 0/5] Enable Linux guests on Hyper-V " Wei Liu
2021-08-04 16:39 ` Michael Kelley
2021-08-04 16:43 ` Catalin Marinas
2021-08-04 16:58 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804162555.GD4857@arm.com \
--to=catalin.marinas@arm.com \
--cc=ardb@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).