Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-efi@vger.kernel.org, jk@ozlabs.org, mjg59@google.com,
	David.Laight@aculab.com,
	Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Subject: Re: [PATCH] efivarfs: revert "fix memory leak in efivarfs_create()"
Date: Wed, 25 Nov 2020 11:27:31 +0100
Message-ID: <309bd3399d042ca94e5bab35980d661c@natalenko.name> (raw)
In-Reply-To: <20201125075303.3963-1-ardb@kernel.org>

On 25.11.2020 08:53, Ard Biesheuvel wrote:
> The memory leak addressed by commit fe5186cf12e3 is a false positive:
> all allocations are recorded in a linked list, and freed when the
> filesystem is unmounted. This leads to double frees, and as reported
> by David, leads to crashes if SLUB is configured to self destruct when
> double frees occur.
> 
> So drop the redundant kfree() again, and instead, mark the offending
> pointer variable so the allocation is ignored by kmemleak.
> 
> Cc: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
> Fixes: fe5186cf12e3 ("efivarfs: fix memory leak in efivarfs_create()")
> Reported-by: David Laight <David.Laight@aculab.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  fs/efivarfs/inode.c | 1 +
>  fs/efivarfs/super.c | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/efivarfs/inode.c b/fs/efivarfs/inode.c
> index 96c0c86f3fff..38324427a2b3 100644
> --- a/fs/efivarfs/inode.c
> +++ b/fs/efivarfs/inode.c
> @@ -103,6 +103,7 @@ static int efivarfs_create(struct inode *dir,
> struct dentry *dentry,
>  	var->var.VariableName[i] = '\0';
> 
>  	inode->i_private = var;
> +	kmemleak_ignore(var);

Do we need to do this as well:

#include <linux/kmemleak.h>

?

Because otherwise for 5.9 I get:

[  148s] fs/efivarfs/inode.c: In function 'efivarfs_create':
[  148s] fs/efivarfs/inode.c:106:2: error: implicit declaration of 
function 'kmemleak_ignore' [-Werror=implicit-function-declaration]
[  148s]   106 |  kmemleak_ignore(var);
[  148s]       |  ^~~~~~~~~~~~~~~

> 
>  	err = efivar_entry_add(var, &efivarfs_list);
>  	if (err)
> diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c
> index f943fd0b0699..15880a68faad 100644
> --- a/fs/efivarfs/super.c
> +++ b/fs/efivarfs/super.c
> @@ -21,7 +21,6 @@ LIST_HEAD(efivarfs_list);
>  static void efivarfs_evict_inode(struct inode *inode)
>  {
>  	clear_inode(inode);
> -	kfree(inode->i_private);
>  }
> 
>  static const struct super_operations efivarfs_ops = {

-- 
   Oleksandr Natalenko (post-factum)

  parent reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  7:53 Ard Biesheuvel
2020-11-25  8:05 ` Oleksandr Natalenko
2020-11-25  8:05   ` Ard Biesheuvel
2020-11-25  8:25     ` Greg Kroah-Hartman
2020-11-25 10:27 ` Oleksandr Natalenko [this message]
2020-11-25 10:28   ` Ard Biesheuvel
2020-11-27 16:50     ` Jonathon Fernyhough
2020-11-27 16:58       ` Ard Biesheuvel
2020-11-27 16:59       ` Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=309bd3399d042ca94e5bab35980d661c@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=David.Laight@aculab.com \
    --cc=ardb@kernel.org \
    --cc=jk@ozlabs.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=vamshi.k.sthambamkadi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git