From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7362C4338F for ; Wed, 18 Aug 2021 05:40:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88EAE61076 for ; Wed, 18 Aug 2021 05:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237833AbhHRFkz (ORCPT ); Wed, 18 Aug 2021 01:40:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229768AbhHRFky (ORCPT ); Wed, 18 Aug 2021 01:40:54 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98F1DC061764; Tue, 17 Aug 2021 22:40:20 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id n7so2975041ljq.0; Tue, 17 Aug 2021 22:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZcizrYLU6y5HJFAgIb30UDjYj0374xDfzw/H/m7g3Nk=; b=USZdPk+yWnkedrOOtr8KxP70SGQYMIXpfOV4rV1oOKtR1tcJmcwAZIO4+d83Hb8tYr AMZ2zSRDxicUtsGndPolzXUSaAqF59yTalnWQjAKsY11/RPMX3aYJVXG7qgHpc6X7uCM jIl70tMsn4zWCRFtNZa+7xTlxgs5G8IUj42zNgX5MSgWZ1gS0IRg8IGvKrQJI05pL/PJ ln6vYv0e9zUn0lKkdtBHC/W5lBkoxGVYLT2kVFFHZLgryJc3zx5WdRPhsCunH+L/U0nt Ehuenp/VllVCgpVifKoreU7rIL416QhLB8oosr3wzph7t1UM61ajKm+w2strKi46/OXz 64Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZcizrYLU6y5HJFAgIb30UDjYj0374xDfzw/H/m7g3Nk=; b=jHLiTyTrzSGAQSmRz2Uj2L2V/OmDzqylfq0lwwPjPJxULyhVSdQHamaXeCtQHY8Jsp SVZiz7bi9VTXB0DPS0UxZCUCfrXQX8NUeRvh4w8Xm2/G+jeMO8Ap/3R/T4H0291rdipp vMNLO5COPUnd9yO3acEWyr5DatMCn5HGOtfmiwLifCBs2Q6bUGSHjrg49+SzxXalVRVa IQpkHCac12SA/bm/L+OJXTHUwAl/dTNPmvEM3qyIUaiUu15Zjlc2xlhxkBkw5ZRnicka czA/cDqiDQalBApqReeDloykfs3UEuM+w14CJyT6wuSj1a5FUG7hE4nugD7pkg2F6wN9 uIzQ== X-Gm-Message-State: AOAM5323l0pIQ8tvVJTAZbFeF1PMWsG3TCHm6DROfp7TrF06KvaQ6T2+ YKUah3BVXPatnvuaHPcbhX8VGP61Gdk= X-Google-Smtp-Source: ABdhPJw2dpwLL1dbQpICuE1/Nqw4koagP47CHNPcipYd/r4HkB0E//zbKzEs+dlJBez4jh3tvWCJiQ== X-Received: by 2002:a2e:934c:: with SMTP id m12mr6046555ljh.375.1629265218423; Tue, 17 Aug 2021 22:40:18 -0700 (PDT) Received: from [192.168.2.145] (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.googlemail.com with ESMTPSA id m5sm461818ljg.55.2021.08.17.22.40.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Aug 2021 22:40:18 -0700 (PDT) Subject: Re: [PATCH v5 2/5] mmc: block: Support alternative_gpt_sector() operation To: Christoph Hellwig Cc: Jens Axboe , Thierry Reding , Jonathan Hunter , Micha?? Miros??aw , David Heidelberg , Peter Geis , Ulf Hansson , Adrian Hunter , Davidlohr Bueso , Rob Herring , Ion Agorria , Svyatoslav Ryhel , linux-tegra@vger.kernel.org, linux-block@vger.kernel.org, linux-efi References: <20210818005547.14497-1-digetx@gmail.com> <20210818005547.14497-3-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <32a009f6-7357-27cc-20e3-247de6f7d786@gmail.com> Date: Wed, 18 Aug 2021 08:40:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org 18.08.2021 08:28, Christoph Hellwig пишет: > On Wed, Aug 18, 2021 at 03:55:44AM +0300, Dmitry Osipenko wrote: >> +static int mmc_blk_alternative_gpt_sector(struct block_device *bdev, >> + sector_t *sector) >> +{ >> + struct mmc_card *card = mmc_bdev_to_card(bdev); >> + >> + if (!card) >> + return -ENODEV; >> + >> + if (!card->host->ops->alternative_gpt_sector) >> + return -EOPNOTSUPP; >> + >> + return card->host->ops->alternative_gpt_sector(card, sector); >> +} >> + > >> +static struct mmc_card *mmc_bdev_to_card(struct block_device *bdev) >> +{ >> + struct mmc_blk_data *md; >> + >> + if (bdev->bd_disk->fops != &mmc_bdops) >> + return NULL; > > No need for this check bow that it is only called through mmc_bdops. Alright >> + >> + md = mmc_blk_get(bdev->bd_disk); >> + if (!md) >> + return NULL; >> + >> + return md->queue.card; >> +} > > This reference seems to never be dropped anywhere. > Indeed, I missed that it bumps the refcnt.