linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Micha?? Miros??aw <mirq-linux@rere.qmqm.pl>,
	David Heidelberg <david@ixit.cz>,
	Peter Geis <pgwipeout@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Ion Agorria <AG0RRIA@yahoo.com>,
	Svyatoslav Ryhel <clamor95@gmail.com>,
	linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
	linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v4 2/3] mmc: block: Add mmc_bdev_to_card() helper
Date: Tue, 17 Aug 2021 19:10:38 +0300	[thread overview]
Message-ID: <3d3d1fe8-cad8-6ff8-9f70-a5580af6d6b5@gmail.com> (raw)
In-Reply-To: <YRs8/zfrU06No+Qv@infradead.org>

17.08.2021 07:37, Christoph Hellwig пишет:
> On Tue, Aug 17, 2021 at 04:36:42AM +0300, Dmitry Osipenko wrote:
>> +	if (bdev->bd_disk->major != MMC_BLOCK_MAJOR)
>> +		return NULL;
> 
> The major is a dangerous check as we have all kinds of ways to override
> it.  Please check the block device operations as they must be unique.
> 

Alright, thank you for the suggestion.

  reply	other threads:[~2021-08-17 16:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  1:36 [PATCH v4 0/3] Support EFI partition on NVIDIA Tegra devices Dmitry Osipenko
2021-08-17  1:36 ` [PATCH v4 1/3] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2021-08-17  1:36 ` [PATCH v4 2/3] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2021-08-17  4:37   ` Christoph Hellwig
2021-08-17 16:10     ` Dmitry Osipenko [this message]
2021-08-17  1:36 ` [PATCH v4 3/3] partitions/efi: Support NVIDIA Tegra devices Dmitry Osipenko
2021-08-17  4:43   ` Christoph Hellwig
2021-08-17 16:11     ` Dmitry Osipenko
2021-08-17  8:24   ` Ulf Hansson
2021-08-17 16:16     ` Dmitry Osipenko
2021-08-17 14:11   ` Thierry Reding
2021-08-17 16:10     ` Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d3d1fe8-cad8-6ff8-9f70-a5580af6d6b5@gmail.com \
    --to=digetx@gmail.com \
    --cc=AG0RRIA@yahoo.com \
    --cc=adrian.hunter@intel.com \
    --cc=axboe@kernel.dk \
    --cc=clamor95@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=david@ixit.cz \
    --cc=hch@infradead.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=pgwipeout@gmail.com \
    --cc=thierry.reding@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).