From: Dmitry Osipenko <digetx@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Micha?? Miros??aw <mirq-linux@rere.qmqm.pl>,
David Heidelberg <david@ixit.cz>,
Peter Geis <pgwipeout@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Randy Dunlap <rdunlap@infradead.org>,
Ion Agorria <AG0RRIA@yahoo.com>,
Svyatoslav Ryhel <clamor95@gmail.com>,
linux-tegra@vger.kernel.org, linux-block@vger.kernel.org,
linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v1 3/3] partitions/efi: Support gpt_sector parameter needed by NVIDIA Tegra devices
Date: Mon, 29 Mar 2021 16:07:39 +0300 [thread overview]
Message-ID: <4666087a-05a5-1065-da17-8dc86248b338@gmail.com> (raw)
In-Reply-To: <20210329061850.GA258398@infradead.org>
29.03.2021 09:18, Christoph Hellwig пишет:
> On Sun, Mar 28, 2021 at 12:21:00AM +0300, Dmitry Osipenko wrote:
>> All NVIDIA Tegra20..124 Android devices use proprietary bootloader
>> which supplies the gpt_sector=<sector> kernel cmdline parameter that
>> should be used for looking up the EFI partition table on internal EMMC
>> storage. If the kernel cmdline parameter isn't supplied, then the
>> partition is expected to be placed around the last but one sector of EMMC.
>>
>> Apparently this was done in order to hide the PT from a usual userspace
>> tools since EFI entry exists only for compatibility with a Linux kernel,
>
> That's weird, because nothin in Linux relies in EFI partition tables.
>
>> while a custom proprietary partition table is what is really used by
>> these Android devices, thus these tools may corrupt the real PT, making
>> device unbootable and very difficult to restore.
>>
>> Add support for the gpt_sector cmdline parameter which will be used
>> for finding EFI entry on internal EMMC storage of NVIDIA Tegra20+ devices.
>
> Didn't we plan to just support the actual partition table format insted?
>
Ideally we need to support both forced-gpt and tegra-partition. At
first we should check whether GPT entry exists and use it on success,
otherwise fall back to tegra-partition. This will allow to properly
support all kind of devices. The majority of devices have the GPT
entry, so will be good to support it at least.
My understanding that this all require involvement from Jens Axboe in
order to get the patches merged. Previously he didn't show interest to
any of the patches and my assumption was that he didn't want to have
another partition, although I don't know for sure because he never answered.
If you could help with reviewing and applying of the patches, then I
will be happy to try again with re-sending a full patchset, which
includes the tegra-partition support.
next prev parent reply other threads:[~2021-03-29 13:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 21:20 [PATCH v1 0/3] Support EFI partition on NVIDIA Tegra devices Dmitry Osipenko
2021-03-27 21:20 ` [PATCH v1 1/3] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko
2021-03-27 21:20 ` [PATCH v1 2/3] mmc: block: Add mmc_bdev_to_card() helper Dmitry Osipenko
2021-03-27 21:21 ` [PATCH v1 3/3] partitions/efi: Support gpt_sector parameter needed by NVIDIA Tegra devices Dmitry Osipenko
2021-03-29 6:18 ` Christoph Hellwig
2021-03-29 13:07 ` Dmitry Osipenko [this message]
2021-03-29 17:31 ` Davidlohr Bueso
2021-03-29 18:38 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4666087a-05a5-1065-da17-8dc86248b338@gmail.com \
--to=digetx@gmail.com \
--cc=AG0RRIA@yahoo.com \
--cc=adrian.hunter@intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=axboe@kernel.dk \
--cc=clamor95@gmail.com \
--cc=dave@stgolabs.net \
--cc=david@ixit.cz \
--cc=hch@infradead.org \
--cc=jonathanh@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=pgwipeout@gmail.com \
--cc=rdunlap@infradead.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).