From: David Laight <David.Laight@ACULAB.COM>
To: 'Ard Biesheuvel' <ardb@kernel.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
"matthew.garrett@nebula.com" <matthew.garrett@nebula.com>,
"jk@ozlabs.org" <jk@ozlabs.org>
Subject: RE: Oops (probably) unmounting /oldroot/firmware/efi/efivars.
Date: Tue, 24 Nov 2020 15:30:42 +0000 [thread overview]
Message-ID: <4bd4f6ca36334473bc55bf3b5704afa1@AcuMS.aculab.com> (raw)
In-Reply-To: <CAMj1kXE3xM__pA6eaXwWV=we4sWrnecH1f7oUbuyGeHc9TPmOg@mail.gmail.com>
From: Ard Biesheuvel
> Sent: 24 November 2020 15:02
> On Tue, 24 Nov 2020 at 15:58, David Laight <David.Laight@aculab.com> wrote:
> >
> > From: Ard Biesheuvel
> > > Sent: 24 November 2020 14:24
> > >
> > > On Tue, 24 Nov 2020 at 15:22, David Laight <David.Laight@aculab.com> wrote:
> > > >
> > > > I've just updated to the head of Linus's tree (5.10-rc5) and got the following
> > > > 'splat' during shutdown.
> > > >
> > > > Userspace is Ubuntu 20.04.
> > > >
> > > > rc4 rebooted fine.
> > > >
> > > > I'll try to bisect - but it isn't quick.
> > > >
> > >
> > > Surely caused by
> > >
> > >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/fs/efivarfs?id=fe5186cf12e30
> > > facfe261e9be6c7904a170bd822
> >
> > Yep, reboots fine with that kfree() commented out.
> >
>
> Thanks for confirming.
>
> Does it also work when keeping the kfree() and setting
> inode->i_private to NULL explicitly afterwards?
No, that still panics.
Setting i_private NULL (but without the kfree()) is ok.
I'm seeing 42 calls with a non-NULL i_private.
The final call has i_private NULL and isn't a duplicate.
There must be another pointer into one of the structures.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-11-24 15:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 14:22 Oops (probably) unmounting /oldroot/firmware/efi/efivars David Laight
2020-11-24 14:23 ` Ard Biesheuvel
2020-11-24 14:42 ` David Laight
2020-11-24 14:57 ` David Laight
2020-11-24 15:01 ` Ard Biesheuvel
2020-11-24 15:30 ` David Laight [this message]
2020-11-24 21:24 ` Oleksandr Natalenko
2020-11-25 8:32 ` Greg Kroah-Hartman
2020-11-25 10:10 ` Oleksandr Natalenko
2020-11-26 20:09 ` Dexuan-Linux Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4bd4f6ca36334473bc55bf3b5704afa1@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).