From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 02/16] efi: Get the secure boot status Date: Mon, 21 Nov 2016 12:41:15 +0000 Message-ID: <5701.1479732075@warthog.procyon.org.uk> References: <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <147933285147.19316.11046583275861569558.stgit@warthog.procyon.org.uk> <20161117123731.GA11573@wunner.de> <29779.1479728545@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: Content-ID: <5700.1479732075.1-S6HVgzuS8uM4Awkfq6JHfwNdhmdF6hFW@public.gmane.org> Sender: linux-efi-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ard Biesheuvel Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Linn Crosetto , Lukas Wunner , keyrings-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Matthew Garrett , linux-security-module , "linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-efi@vger.kernel.org Ard Biesheuvel wrote: > > Looking in efi_get_secureboot(), is there a reason: > > > > efi_guid_t var_guid = EFI_GLOBAL_VARIABLE_GUID; > > > > isn't static const? > > > > Not a good one, no. It used to be static const, but for some reason, > commit 30d7bf034c03 ("efi/arm64: Check SetupMode when determining > Secure Boot status") removed the static and the const (and I reviewed > it and did not complain AFAIR) > I'll gladly take a patch that reinstates that, though. Also, is there a reason that: typedef efi_status_t efi_get_variable_t (efi_char16_t *name, efi_guid_t *vendor, u32 *attr, unsigned long *data_size, void *data); Doesn't have const name and vendor? David