From: David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Josh Boyer <jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
Cc: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Matt Fleming
<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] efi: Add SHIM and image security database GUID definitions
Date: Tue, 25 Oct 2016 12:59:18 -0700 [thread overview]
Message-ID: <580FB996.9000302@caviumnetworks.com> (raw)
In-Reply-To: <CA+5PVA4-BnZWv2rktX+LrQT-N6jd8bT-FKgvxi8E4xDhNsruRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 10/25/2016 11:25 AM, Josh Boyer wrote:
> On Tue, Oct 25, 2016 at 2:15 PM, David Daney <ddaney-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> wrote:
>> On 10/25/2016 11:04 AM, Josh Boyer wrote:
>>>
>>> On Tue, Oct 25, 2016 at 1:44 PM, Ard Biesheuvel
>>> <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>>>>
>>>> Hi Josh,
>>>>
>>>> On 25 October 2016 at 18:42, Josh Boyer <jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
>>>> wrote:
>>>>>
>>>>> Add the definitions for shim and image security database, both of which
>>>>> are used widely in various Linux distros.
>>>>>
>>>>> Signed-off-by: Josh Boyer <jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
>>>>> ---
>>>>> include/linux/efi.h | 3 +++
>>>>> 1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/include/linux/efi.h b/include/linux/efi.h
>>>>> index 2d089487d2da..ce943d5accfd 100644
>>>>> --- a/include/linux/efi.h
>>>>> +++ b/include/linux/efi.h
>>>>> @@ -592,6 +592,9 @@ void efi_native_runtime_setup(void);
>>>>> #define EFI_MEMORY_ATTRIBUTES_TABLE_GUID EFI_GUID(0xdcfa911d,
>>>>> 0x26eb, 0x469f, 0xa2, 0x20, 0x38, 0xb7, 0xdc, 0x46, 0x12, 0x20)
>>>>> #define EFI_CONSOLE_OUT_DEVICE_GUID EFI_GUID(0xd3b36f2c,
>>>>> 0xd551, 0x11d4, 0x9a, 0x46, 0x00, 0x90, 0x27, 0x3f, 0xc1, 0x4d)
>>>>>
>>>>> +#define EFI_IMAGE_SECURITY_DATABASE_GUID EFI_GUID(0xd719b2cb,
>>>>> 0x3d3a, 0x4596, 0xa3, 0xbc, 0xda, 0xd0, 0x0e, 0x67, 0x65, 0x6f)
>>>>> +#define EFI_SHIM_LOCK_GUID
>>>>> EFI_GUID(0x605dab50, 0xe046, 0x4300, 0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd,
>>>>> 0x8b, 0x23)
>>>>> +
>>>>
>>>>
>>>> Given that this patch is not part of the series, could you explain
>>>> what the point is of having these definitions in the kernel if they
>>>> are never referenced?
>>>
>>>
>>> Sure.
>>>
>>> The idea is to make sure a commonly used definition is both accessible
>>> and reserved in the kernel.
>>
>>
>> It is not in a uapi directory, so it cannot be used outside of the kernel.
>
> Fair point. Would there be value in creating an efi.h in uapi so that
> it can serve as the canonical source?
I doubt it. The kernel source tree is not meant to serve as an
authoritative registry for assigned numbers used by external projects.
>
> josh
>
next prev parent reply other threads:[~2016-10-25 19:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 17:42 [PATCH] efi: Add SHIM and image security database GUID definitions Josh Boyer
[not found] ` <20161025174209.29073-1-jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
2016-10-25 17:44 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8jkPMG4KGjg+UTeuLOe6m=g3KMKsC=BgwVegyBYnHm0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-25 17:44 ` Ard Biesheuvel
2016-10-25 18:04 ` Josh Boyer
[not found] ` <CA+5PVA53Tf2QVN0j0JFO9_v-hGbsg9HByOGGfLCGsgeGCz5UKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-25 18:15 ` David Daney
[not found] ` <580FA136.80006-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-10-25 18:25 ` Josh Boyer
[not found] ` <CA+5PVA4-BnZWv2rktX+LrQT-N6jd8bT-FKgvxi8E4xDhNsruRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-25 19:59 ` David Daney [this message]
[not found] ` <580FB996.9000302-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
2016-10-26 8:01 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=580FB996.9000302@caviumnetworks.com \
--to=ddaney-m3mlkvoiwjvv6pq1l3v1odbpr1lh4cv8@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=jwboyer-rxtnV0ftBwyoClj4AeEUq9i2O/JbrIOy@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).