From: Smita Koralahalli Channabasappa <skoralah@amd.com>
To: Punit Agrawal <punit1.agrawal@toshiba.co.jp>,
Borislav Petkov <bp@alien8.de>
Cc: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-edac@vger.kernel.org,
linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org,
Tony Luck <tony.luck@intel.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH v5] cper, apei, mce: Pass x86 CPER through the MCA handling chain
Date: Wed, 11 Nov 2020 14:37:29 -0600 [thread overview]
Message-ID: <651b7dba-d36a-d4db-4a0f-fd67aa9b985f@amd.com> (raw)
In-Reply-To: <982e0243-b144-f8b6-d69d-45af94ed8bb9@amd.com>
Punit,
On 11/9/20 1:05 PM, Smita Koralahalli Channabasappa wrote:
> On 11/8/20 7:18 PM, Punit Agrawal wrote:
>> Borislav Petkov <bp@alien8.de> writes:
>>> On Fri, Nov 06, 2020 at 02:36:46PM +0900, Punit Agrawal wrote:
>>>>> diff --git a/drivers/firmware/efi/cper-x86.c b/drivers/firmware/efi/cper-x86.c
>>>>> index 2531de49f56c..438ed9eff6d0 100644
>>>>> --- a/drivers/firmware/efi/cper-x86.c
>>>>> +++ b/drivers/firmware/efi/cper-x86.c
>>>>> @@ -2,6 +2,7 @@
>>>>> // Copyright (C) 2018, Advanced Micro Devices, Inc.
>>>>> #include <linux/cper.h>
>>>>> +#include <linux/acpi.h>
>>>> Did you mean to include <asm/acpi.h>?
>>> Why?
>> Because arch_apei_report_x86_error() used in the patch is defined
>> there. The indirect include works but pulls in additional definitions
>> not needed by the patch.
>>
>> Do you prefer the more generic include?
> I agree, it's generally a good practice to avoid pulling up additional
> definitions. I had this when I made the declaration in generic header
> file and may be I did not consider it changing initially as my build
> didn't break after moving the declaration from generic header to arch
> specific header file.
> I will take care henceforth and make the changes as required.
The asm specific include throws out a warning when I run checkpatch.pl
WARNING: Use #include <linux/acpi.h> instead of <asm/acpi.h>
#215: FILE: drivers/firmware/efi/cper-x86.c:5:
+#include <asm/acpi.h>
Should I just keep the generic include?
Thanks,
Smita
next prev parent reply other threads:[~2020-11-11 20:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 16:49 [PATCH v5] cper, apei, mce: Pass x86 CPER through the MCA handling chain Smita Koralahalli
2020-11-06 5:36 ` Punit Agrawal
2020-11-06 12:09 ` Borislav Petkov
2020-11-09 1:18 ` Punit Agrawal
2020-11-09 19:05 ` Smita Koralahalli Channabasappa
2020-11-11 20:37 ` Smita Koralahalli Channabasappa [this message]
2020-11-13 1:40 ` Punit Agrawal
2020-11-06 12:09 ` Borislav Petkov
2020-11-09 18:36 ` Smita Koralahalli Channabasappa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=651b7dba-d36a-d4db-4a0f-fd67aa9b985f@amd.com \
--to=skoralah@amd.com \
--cc=Smita.KoralahalliChannabasappa@amd.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=punit1.agrawal@toshiba.co.jp \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).