From: Daniel Drake <drake@endlessm.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Jian-Hong Pan <jian-hong@endlessm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
Ard Biesheuvel <ardb@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
x86@kernel.org, Linux Kernel <linux-kernel@vger.kernel.org>,
linux-efi@vger.kernel.org,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T"
Date: Fri, 20 Mar 2020 20:37:54 +0800 [thread overview]
Message-ID: <CAD8Lp47ndRqeS5VbkCMR_Faq-du9eDW28rHOG4Owxq862t-kGQ@mail.gmail.com> (raw)
In-Reply-To: <20200312104643.GA15619@zn.tnic>
On Thu, Mar 12, 2020 at 6:46 PM Borislav Petkov <bp@alien8.de> wrote:
> How do you know *everyone* affected will update their BIOS?
>
> And what's the downside of keeping it?
It could indeed be kept without user-visible downside, and that would
be the normal case for quirks that work around BIOS bugs.
But I had two reasons for suggesting that Jian-Hong should send this
revert patch, which may be worth some consideration:
1. This was working around a BIOS bug truly separate from Linux to
the point where it was a little questionable for Linux to put a quirk
in place. The original bug was that after Linux completed executing
the reboot code, the machine would reboot, the BIOS would start
loading, and then crash well before loading the OS. Presumably
crashing on some state that Linux left that was not reset in the
machine's reboot stage. The vendor later found the issue (something
TPM-related) and fixed the BIOS to avoid the crash.
2. We normally receive these units before they go into mass
production, so there's a decent chance that production versions
already include this BIOS fix.
Based on that I was considering that the patch could be reverted for
cleanliness/ At the same time, I do not have strong feelings on this,
no issues if the quirk is left in place.
Daniel
next prev parent reply other threads:[~2020-03-20 12:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 8:33 [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T" Jian-Hong Pan
2020-03-12 10:46 ` Borislav Petkov
2020-03-16 9:17 ` Jian-Hong Pan
2020-03-16 10:02 ` Borislav Petkov
2020-03-18 6:58 ` Jian-Hong Pan
2020-03-20 12:37 ` Daniel Drake [this message]
2020-03-20 13:54 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD8Lp47ndRqeS5VbkCMR_Faq-du9eDW28rHOG4Owxq862t-kGQ@mail.gmail.com \
--to=drake@endlessm.com \
--cc=anton@enomsg.org \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=ccross@android.com \
--cc=hpa@zytor.com \
--cc=jian-hong@endlessm.com \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).