From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD379C388F3 for ; Tue, 1 Oct 2019 08:55:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 818A821855 for ; Tue, 1 Oct 2019 08:55:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uFyk/p3b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733116AbfJAIy5 (ORCPT ); Tue, 1 Oct 2019 04:54:57 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:36097 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbfJAIyz (ORCPT ); Tue, 1 Oct 2019 04:54:55 -0400 Received: by mail-wm1-f66.google.com with SMTP id m18so2294742wmc.1 for ; Tue, 01 Oct 2019 01:54:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tCMVcJHTL1rAZzsr8sC7UBxH5shgJjc8cOwozajIRmU=; b=uFyk/p3bEIkTDdel/ZCSZdqV7nMh2YBxg0Lzcp/K0V07uZvkv3pN1YJJebLzjgYd6N tDj/bBmdRRq5q6K9i4BXzb2dJ8F7RLKA4oORNy5o6+C/yWJ8RUTubCLj7vkrserUvACl GoGIG3aFLT4z1twhfPXk8SacX1BseglsI64eXx7wB9gM9KcXXxhjay3OEvMfdD4MBtEK 8susq8F32cbzP+8K1Lik32U0pvsgDZO2NXxOhfzjetU6kBU7//fz+k354MP9Q1UlfvIG kEUEUc2WcKPHQp0bIfoHYl+YEjNy6SKIC43iwR9+Sg0n0F1pJVtvQZXJ/xB5IlWpwELK CszA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tCMVcJHTL1rAZzsr8sC7UBxH5shgJjc8cOwozajIRmU=; b=uU/KgBP75Rf9i2tPCWqDVwwAaKK9NLSDCMgc/q3ZYLJUCYtnNWKF71RItUICEqznS9 3v/YV71ud813FM+uG15le3Pp8KhD9pTioTSRdJedp2SEdCu6G4ociKlQdFBKuv8oXGEO smOdbL/5dka1GQPYqdLyGTz9NibtDB8CWQzbprQUyzdxJeu80wWVYjj2FSWcRUXg/8f0 8VvKykcljWW76QVBL0vkG0Fk2+wB9I+Uv9J+jIqxdCBWy6//TQa047lm9ou+dOafLJo1 +MmHLrhkbXrmvtkZt0nlfiUtnmLwqAH+R+wOkpWAyE8bs2Hukszv7kgKnjeiOs5lBw4V ZTcw== X-Gm-Message-State: APjAAAUYz8VNKi3diyjRwkxpZkTU6Uu6OC7/o4cLFftHgnxTZjeTSeVl 8Jc/j+AfLzMAWsiDWW/tVvdJi8icqgjHMKgJL/ND0A== X-Google-Smtp-Source: APXvYqyKcvl41Sw5NIkOgDT2b+yl0RkNvIrnfAAemKqyZcpgreGVpLtLWgKKUHFHIcLTVadVs6hMX38D1RSVozLO5Ls= X-Received: by 2002:a1c:3cc3:: with SMTP id j186mr2551070wma.119.1569920093430; Tue, 01 Oct 2019 01:54:53 -0700 (PDT) MIME-Version: 1.0 References: <20190812150452.27983-1-ard.biesheuvel@linaro.org> <20190812150452.27983-5-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Tue, 1 Oct 2019 10:54:40 +0200 Message-ID: Subject: Re: [PATCH 4/5] efi: Export Runtime Configuration Interface table to sysfs To: Geert Uytterhoeven Cc: Narendra K , linux-efi , Ingo Molnar , Thomas Gleixner , Linux Kernel Mailing List , James Morse , Mario Limonciello , Xiaofei Tan Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Tue, 1 Oct 2019 at 10:51, Geert Uytterhoeven wrote: > > Hi Ard, Narendra, > > On Mon, Aug 12, 2019 at 5:07 PM Ard Biesheuvel > wrote: > > From: Narendra K > > > > System firmware advertises the address of the 'Runtime > > Configuration Interface table version 2 (RCI2)' via > > an EFI Configuration Table entry. This code retrieves the RCI2 > > table from the address and exports it to sysfs as a binary > > attribute 'rci2' under /sys/firmware/efi/tables directory. > > The approach adopted is similar to the attribute 'DMI' under > > /sys/firmware/dmi/tables. > > > > RCI2 table contains BIOS HII in XML format and is used to populate > > BIOS setup page in Dell EMC OpenManage Server Administrator tool. > > The BIOS setup page contains BIOS tokens which can be configured. > > > > Signed-off-by: Narendra K > > Reviewed-by: Mario Limonciello > > Signed-off-by: Ard Biesheuvel > > Thanks, this is now commit 1c5fecb61255aa12 ("efi: Export Runtime > Configuration Interface table to sysfs"). > > > --- a/drivers/firmware/efi/Kconfig > > +++ b/drivers/firmware/efi/Kconfig > > @@ -180,6 +180,19 @@ config RESET_ATTACK_MITIGATION > > have been evicted, since otherwise it will trigger even on clean > > reboots. > > > > +config EFI_RCI2_TABLE > > + bool "EFI Runtime Configuration Interface Table Version 2 Support" > > + help > > + Displays the content of the Runtime Configuration Interface > > + Table version 2 on Dell EMC PowerEdge systems as a binary > > + attribute 'rci2' under /sys/firmware/efi/tables directory. > > + > > + RCI2 table contains BIOS HII in XML format and is used to populate > > + BIOS setup page in Dell EMC OpenManage Server Administrator tool. > > + The BIOS setup page contains BIOS tokens which can be configured. > > + > > + Say Y here for Dell EMC PowerEdge systems. > > A quick Google search tells me these are Intel Xeon. > Are arm/arm64/ia64 variants available, too? > If not, this should be protected by "depends on x86" ("|| COMPILE_TEST"?). > Hello Geert, The code in question is entirely architecture agnostic, and defaults to 'n', so I am not convinced this is needed. (It came up in the review as well)