From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC62C43603 for ; Thu, 5 Dec 2019 12:06:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51C052245C for ; Thu, 5 Dec 2019 12:06:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="z7ZjjcPl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729165AbfLEMGf (ORCPT ); Thu, 5 Dec 2019 07:06:35 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53706 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729109AbfLEMGe (ORCPT ); Thu, 5 Dec 2019 07:06:34 -0500 Received: by mail-wm1-f68.google.com with SMTP id n9so2934912wmd.3 for ; Thu, 05 Dec 2019 04:06:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C/JXqQuIVvELZvtbxu4JQIb34IcftH1RWqiFbYiSOGw=; b=z7ZjjcPlFZoSP8s8Yid633QhPgkfMoMug2fZdoYMvesbPo3kL6yFewLz4cK2hZaKR1 YN4IckKVBnOw2Q/bomnvNdOfi3PKL0DT7dhn3PSSB+ICCQnPjsz6ZKQ/ln+Ewr9NOid3 J3CdYJ0zR315TO4mYgv39UV9JYI466S0ZEVdISdK+FhnqaH/ENC7mim00IcwMlZDxnbT UWA+GscY34vcPDXwG5nVYRVcp74AXSbcYeEjV/AUhfS148C+c4UhBmjvjW8hm+mkRNlu vVL5lTkydSeNEDs6y+kD2luk2dL+HLnJT1mpKDCpZPbYgHcT0pB8KktIcvYzb20RwDpj HxSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C/JXqQuIVvELZvtbxu4JQIb34IcftH1RWqiFbYiSOGw=; b=rgThpBX6RmV/MiyxGSDJm7auW8e7CCXWaPH1kgfOWSV12uYdFSY9FLFqDtZCx6jVdm z9Wvj/eJ6lmq7H8oZQusFem9mp0+0KRkJTUBmuYHsqr9VF6ITbUMwD4Y8Y7WhKiEh5fC QdwxoyW9IoXsP6TBq7YC55gacXMiQ7nJVXDBn75wHTO4M9Yr+gNRJlHb6SCYaeahIXuS Kj6N4eqq6VaenXfXivN11vth0/E40sRG34o8N1EjxnXzmlE78sscQsK4xYeEp88I1581 qwSvlXXUMMyOffC3p79ivbPQll3gAr5/9E39rWud3tJy+SIyZkP7gOoYv7xL+DQNnlWt rDxw== X-Gm-Message-State: APjAAAU/OY/MSb38ARuQ+ZmkZqUoH6ZNk7/CZsxdtbBKWQ/yEDsRdoBH GWdMuCQuXPaQ7Itlm17bqKpmKTMoMfvLdPWEFLFOzA== X-Google-Smtp-Source: APXvYqy85reIbZ8QXiZ/PEqNQKl+Demi4htlOfZitXwaMsbYicieDHPmFH1TCxMakhhkYilEksWoyssxFjQJiN9KySM= X-Received: by 2002:a1c:7205:: with SMTP id n5mr5016253wmc.9.1575547592616; Thu, 05 Dec 2019 04:06:32 -0800 (PST) MIME-Version: 1.0 References: <20191203214728.19264-1-nivedita@alum.mit.edu> <20191204181744.14326-1-nivedita@alum.mit.edu> In-Reply-To: <20191204181744.14326-1-nivedita@alum.mit.edu> From: Ard Biesheuvel Date: Thu, 5 Dec 2019 12:06:29 +0000 Message-ID: Subject: Re: [PATCH v2 0/3] Fix a couple of bugs in efi/gop.c To: Arvind Sankar Cc: Ard Biesheuvel , linux-efi Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, 4 Dec 2019 at 18:17, Arvind Sankar wrote: > > Changes from v1: > - Split return value patch into two as requested. > - Remove the __gop_query functions > > Arvind Sankar (3): > efi/gop: Return EFI_NOT_FOUND if there are no usable GOP's > efi/gop: Return EFI_SUCCESS if a usable GOP was found > efi/gop: Fix memory leak from __gop_query32/64 > Thanks Arvind I queued your changes as fixes here: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git/log/?h=urgent I intend to send them out for inclusion in v5.5 in a week or so. > drivers/firmware/efi/libstub/gop.c | 76 +++++++----------------------- > 1 file changed, 17 insertions(+), 59 deletions(-) > > -- > 2.23.0 >