Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] efi/libstub: describe RNG functions
@ 2020-02-21 11:47 Heinrich Schuchardt
  2020-02-21 16:30 ` Dominik Brodowski
  0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2020-02-21 11:47 UTC (permalink / raw)
  To: Ard Biesheuvel
  Cc: Ingo Molnar, Dominik Brodowski, Dan Williams, Hans de Goede,
	linux-efi, linux-kernel, Heinrich Schuchardt

Provide descriptions for the functions invoking the EFI_RNG_PROTOCOL.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/firmware/efi/libstub/random.c | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/firmware/efi/libstub/random.c b/drivers/firmware/efi/libstub/random.c
index 21e7e9325219..24aa37535372 100644
--- a/drivers/firmware/efi/libstub/random.c
+++ b/drivers/firmware/efi/libstub/random.c
@@ -25,6 +25,17 @@ union efi_rng_protocol {
 	} mixed_mode;
 };

+/**
+ * efi_get_random_bytes() - fill a buffer with random bytes
+ * @size:	size of the buffer
+ * @out:	caller allocated buffer to receive the random bytes
+ *
+ * The call will fail if either the firmware does not implement the
+ * EFI_RNG_PROTOCOL or there are not enough random bytes available to fill
+ * the buffer.
+ *
+ * Return:	status code
+ */
 efi_status_t efi_get_random_bytes(unsigned long size, u8 *out)
 {
 	efi_guid_t rng_proto = EFI_RNG_PROTOCOL_GUID;
@@ -38,6 +49,19 @@ efi_status_t efi_get_random_bytes(unsigned long size, u8 *out)
 	return efi_call_proto(rng, get_rng, NULL, size, out);
 }

+/**
+ * efi_random_get_seed() - provide random seed as configuration table
+ *
+ * The EFI_RNG_PROTOCOL is used to read random bytes. These random bytes are
+ * saved as a configuration table which can be used as entropy by the kernel
+ * for the initialization of its pseudo random number generator.
+ *
+ * If the EFI_RNG_PROTOCOL is not available or there are not enough random bytes
+ * available, the configuration table will not be installed and an error code
+ * will be returned.
+ *
+ * Return:	status code
+ */
 efi_status_t efi_random_get_seed(void)
 {
 	efi_guid_t rng_proto = EFI_RNG_PROTOCOL_GUID;
--
2.25.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] efi/libstub: describe RNG functions
  2020-02-21 11:47 [PATCH 1/1] efi/libstub: describe RNG functions Heinrich Schuchardt
@ 2020-02-21 16:30 ` Dominik Brodowski
  2020-02-22 17:51   ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Dominik Brodowski @ 2020-02-21 16:30 UTC (permalink / raw)
  To: Heinrich Schuchardt
  Cc: Ard Biesheuvel, Ingo Molnar, Dan Williams, Hans de Goede,
	linux-efi, linux-kernel

On Fri, Feb 21, 2020 at 12:47:16PM +0100, Heinrich Schuchardt wrote:
> Provide descriptions for the functions invoking the EFI_RNG_PROTOCOL.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>

Thanks,
	Dominik

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] efi/libstub: describe RNG functions
  2020-02-21 16:30 ` Dominik Brodowski
@ 2020-02-22 17:51   ` Ard Biesheuvel
  0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2020-02-22 17:51 UTC (permalink / raw)
  To: Dominik Brodowski
  Cc: Heinrich Schuchardt, Ingo Molnar, Dan Williams, Hans de Goede,
	linux-efi, Linux Kernel Mailing List

On Fri, 21 Feb 2020 at 17:30, Dominik Brodowski
<linux@dominikbrodowski.net> wrote:
>
> On Fri, Feb 21, 2020 at 12:47:16PM +0100, Heinrich Schuchardt wrote:
> > Provide descriptions for the functions invoking the EFI_RNG_PROTOCOL.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>
> Reviewed-by: Dominik Brodowski <linux@dominikbrodowski.net>
>

Queued in efi/next

Thanks,

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 11:47 [PATCH 1/1] efi/libstub: describe RNG functions Heinrich Schuchardt
2020-02-21 16:30 ` Dominik Brodowski
2020-02-22 17:51   ` Ard Biesheuvel

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git