From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-efi <linux-efi@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Wilfried Klaebe <linux-kernel@lebenslange-mailadresse.de>
Subject: Re: [GIT PULL 0/1] EFI mixed mode fix for v4.18
Date: Wed, 11 Jul 2018 12:24:03 +0200 [thread overview]
Message-ID: <CAKv+Gu8m4UgL0GyYDuu5z+dzEF=N--H4PkqoO_xqwyW2_A+RMA@mail.gmail.com> (raw)
In-Reply-To: <20180711101303.GA8574@gmail.com>
On 11 July 2018 at 12:13, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
>> The following changes since commit 1e4b044d22517cae7047c99038abb444423243ca:
>>
>> Linux 4.18-rc4 (2018-07-08 16:34:02 -0700)
>>
>> are available in the Git repository at:
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git tags/efi-urgent
>>
>> for you to fetch changes up to d7f2e972e702d329fe11d6956df99dfc31211c25:
>>
>> efi/x86: remove pointless call to PciIo->Attributes() (2018-07-11 10:52:46 +0200)
>>
>> ----------------------------------------------------------------
>> A single fix for the x86 PCI I/O protocol handling code that got
>> broken for mixed mode (64-bit Linux/x86 on 32-bit UEFI) after a
>> fix was applied in -rc2 to fix it for ordinary 64-bit Linux/x86.
>
> Just curious, because it's unclear from the changelog, what was the symptom, a
> boot hang, instant reboot, or some other misbehavior?
Hans reported that his mixed mode tablet would not boot at all any
more, but enter a reboot loop without any logs printed by the kernel.
> Also, what's the scope of
> the fix: were all 64-bit on 32-bit UEFI mixed-mode bootups affected, or only a
> certain subset?
>
Any mixed mode system with PCI is likely to be affected. I have added
a QEMU mixed mode config to my boot test environment to catch errors
like this one.
The unfortunate thing here is that this uncovered a fundamental issue
with mixed mode, i.e., that any UEFI protocol prototype involving
64-bit by-value parameters needs to be special cased in the stub code,
which is rather tedious. There is one other call that is potentially
affected, a file open call in the initrd handling code, but that
specific occurrence happens to work unmodified. This patch removes the
other one. Going forward, we will have to carefully review UEFI
protocol invocations for mixed mode compatibility.
next prev parent reply other threads:[~2018-07-11 10:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 9:02 [GIT PULL 0/1] EFI mixed mode fix for v4.18 Ard Biesheuvel
2018-07-11 9:02 ` [PATCH 1/1] efi/x86: remove pointless call to PciIo->Attributes() Ard Biesheuvel
2018-07-11 10:13 ` [GIT PULL 0/1] EFI mixed mode fix for v4.18 Ingo Molnar
2018-07-11 10:23 ` Hans de Goede
2018-07-11 10:24 ` Ard Biesheuvel [this message]
2018-07-11 11:14 ` Ingo Molnar
2018-07-11 13:44 ` Ard Biesheuvel
2018-07-11 15:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu8m4UgL0GyYDuu5z+dzEF=N--H4PkqoO_xqwyW2_A+RMA@mail.gmail.com' \
--to=ard.biesheuvel@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@lebenslange-mailadresse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).