linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Cc: Kees Cook <keescook@chromium.org>,
	Tony Luck <tony.luck@intel.com>,
	Matt Fleming <matt@codeblueprint.co.uk>,
	"Gao, Liming" <liming.gao@intel.com>,
	linux-efi <linux-efi@vger.kernel.org>
Subject: Re: [PATCH v6 0/2] Add capsule-pstore backend support
Date: Sun, 15 Mar 2020 09:56:34 -0400	[thread overview]
Message-ID: <CAKv+Gu9BvqZavV6XjfuacXXpabNCXLYEw-f=81fwX8hdL6Fn-A@mail.gmail.com> (raw)
In-Reply-To: <20200312011312.70653-1-qiuxu.zhuo@intel.com>

On Wed, 11 Mar 2020 at 21:12, Qiuxu Zhuo <qiuxu.zhuo@intel.com> wrote:
>
> Change Log v5->v6:
>   Part1: No changes.
>   Part2: Update capsule-pstore.c file header.
>          Move the variable 'efi_capsule_pstore_info' backward (for removing some function declarations).
>

This conflicts badly with the efi/core changes queued up in the tip
tree (and hence linux-next) Please rebase and repost


>
> History:
>   The v5 was sent about two years ago [1]. At that time there was a concern about the EFI system table
>   entry 'CapsulePtr' as below: whether it was an array of capsules or an array of pointers to capsules.
>
>       typedef struct { UINT32 CapsuleArrayNumber; VOID* CapsulePtr[1]; } EFI_CAPSULE_TABLE;
>
>   The latest UEFI specification v2.8 [2] has a clarification in P268 for 'CapsulePtr'  as below:
>
>       "CapsulePtr A pointer to an array of capsules that contain the same CapsuleGuid value.
>        Each CapsulePtr points to an instance of an EFI_CAPSULE_HEADER, with the capsule data
>        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>        concatenated on its end."
>        ^^^^^^^^^^^^^^^^^^^^^^^
>
>   According to the highlighted description above, the 'CapsulePtr' should be an array of pointers to capsules.
>   The capsule-pstore driver and the tested BIOS also use the 'CapsulePtr' as an array of pointers to capsules.
>
>
> Test:
>   The v6 is well-tested on an Intel Kaby Lake client platform + BIOS(10/24/2016) and an Intel Ice Lake
>   client platform + BIOS(09/12/2019).
>
> Reference:
>   [1] https://lore.kernel.org/linux-efi/?q=capsule-pstore
>   [2] https://uefi.org/sites/default/files/resources/UEFI_Spec_2_8_A_Feb14.pdf
>
> Qiuxu Zhuo (2):
>   efi: Add 'nr_config_table' variable in efi structure
>   eif/capsule-pstore: Add capsule pstore backend
>
>  arch/x86/platform/efi/efi.c           |   1 +
>  drivers/firmware/efi/Kconfig          |  21 +
>  drivers/firmware/efi/Makefile         |   1 +
>  drivers/firmware/efi/arm-init.c       |   4 +-
>  drivers/firmware/efi/capsule-pstore.c | 692 ++++++++++++++++++++++++++
>  drivers/firmware/efi/efi.c            |   1 +
>  include/linux/efi.h                   |   1 +
>  7 files changed, 720 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/firmware/efi/capsule-pstore.c
>
> --
> 2.17.1
>

  reply	other threads:[~2020-03-15 13:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-12  1:13 [PATCH v6 0/2] Add capsule-pstore backend support Qiuxu Zhuo
2020-03-15 13:56 ` Ard Biesheuvel [this message]
2020-03-15 14:45   ` Zhuo, Qiuxu
2020-03-16  5:32   ` Zhuo, Qiuxu
2020-03-18 20:19     ` Ard Biesheuvel
2020-03-19  8:53       ` Zhuo, Qiuxu
2020-03-20 19:25         ` Luck, Tony
2020-03-25 15:52           ` Ard Biesheuvel
2020-03-25 17:33             ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9BvqZavV6XjfuacXXpabNCXLYEw-f=81fwX8hdL6Fn-A@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=keescook@chromium.org \
    --cc=liming.gao@intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=qiuxu.zhuo@intel.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).