From: Ard Biesheuvel <ardb@kernel.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"the arch/x86 maintainers" <x86@kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v2] x86/efi: Add additional efi tables for unencrypted mapping checks
Date: Tue, 25 Feb 2020 18:58:18 +0100 [thread overview]
Message-ID: <CAKv+Gu_0LUY67DwSLU1tyijuF+0mKPpvq1j3RSMy5HBxYE-3qw@mail.gmail.com> (raw)
In-Reply-To: <9e16fed9-4399-5c78-cbfb-6be75c295f31@amd.com>
On Tue, 25 Feb 2020 at 18:54, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>
> On 2/25/20 11:45 AM, Ard Biesheuvel wrote:
> > On Tue, 25 Feb 2020 at 18:41, Tom Lendacky <thomas.lendacky@amd.com> wrote:
> >>
> >> When booting with SME active, EFI tables must be mapped unencrypted since
> >> they were built by UEFI in unencrypted memory. Update the list of tables
> >> to be checked during early_memremap() processing to account for new EFI
> >> tables.
> >>
> >> This fixes a bug where an EFI TPM log table has been created by UEFI, but
> >> it lives in memory that has been marked as usable rather than reserved.
> >>
> >> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> >>
> >> ---
> >> Changes since v1:
> >> - Re-spun against EFI tree
> >
> > Which one? Surely not the one in the link I included?
>
> I did a git clone of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git
>
> and checked out branch next. Not sure what I missed...
>
Weird. Do you see commit 5d288dbd88606d8f215c7138b10649115d79cadd on
that branch? It removes rng_seed from struct efi, hence my request to
rebase your patch.
IMO, best is to simply drop the 'static' from rng_seed, rename it to
efi_rng_seed, and drop an extern declaration in linux/efi.h so it is
accessible from your code. I'm reluctant to put it back in struct efi.
next prev parent reply other threads:[~2020-02-25 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 17:41 [PATCH v2] x86/efi: Add additional efi tables for unencrypted mapping checks Tom Lendacky
2020-02-25 17:45 ` Ard Biesheuvel
2020-02-25 17:54 ` Tom Lendacky
2020-02-25 17:58 ` Ard Biesheuvel [this message]
2020-02-25 18:10 ` Tom Lendacky
2020-02-25 18:12 ` Ard Biesheuvel
2020-02-25 19:21 ` Tom Lendacky
2020-02-25 19:28 ` Ard Biesheuvel
2020-02-25 19:35 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_0LUY67DwSLU1tyijuF+0mKPpvq1j3RSMy5HBxYE-3qw@mail.gmail.com \
--to=ardb@kernel.org \
--cc=andy@infradead.org \
--cc=bp@alien8.de \
--cc=dvhart@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).