Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Scott Talbert <swt@techie.net>
Cc: linux-efi <linux-efi@vger.kernel.org>
Subject: Re: Boot regression in 4.8 for Mac Pro server
Date: Thu, 12 Sep 2019 00:17:30 +0100
Message-ID: <CAKv+Gu_9oeMWA0_dcBkg1s2XaR4H_axGgjQ9pWELACD9uQ-0hg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1909111635530.3954@bear.techie.net>

On Wed, 11 Sep 2019 at 21:48, Scott Talbert <swt@techie.net> wrote:
>
> Hi,
>
> I just recently discovered a boot regression that occurred starting in 4.8
> on a Mac Pro Mid-2012 server (MacPro5,1).  Yes, I realize this problem is
> over 3 years old.  Obviously, I haven't been using Linux on this hardware
> in a while.  :-)  I bisected the regression to
> 475fb4e8b2f4444d1d7b406ff3a7d21bc89a1e6f "efi / ACPI: load SSTDs from EFI
> variables".  And indeed, v5.3-rc7 will boot if I comment out the
> efivar_ssdt_load() call, as in:
>
> $ git diff
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index ad3b1f4866b3..691a8671a2ba 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -364,8 +364,8 @@ static int __init efisubsys_init(void)
>          if (error)
>                  goto err_put;
>
> -       if (efi_enabled(EFI_RUNTIME_SERVICES))
> -               efivar_ssdt_load();
> +       //if (efi_enabled(EFI_RUNTIME_SERVICES))
> +       //      efivar_ssdt_load();
>
>          error = sysfs_create_group(efi_kobj, &efi_subsys_attr_group);
>          if (error) {
>
>
> Any thoughts on how to fix this?
>

Thanks for the report. It appears the SSDT loading code is slightly
broken, in the sense that it always iterates over all EFI variables
regardless of whether an SSDT override was actually requested on the
command line, which is silly.

I'll have a patch out shortly, and I'll put you on cc. Please test it
and report back.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-11 20:42 Scott Talbert
2019-09-11 23:17 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_9oeMWA0_dcBkg1s2XaR4H_axGgjQ9pWELACD9uQ-0hg@mail.gmail.com \
    --to=ard.biesheuvel@linaro.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=swt@techie.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org linux-efi@archiver.kernel.org
	public-inbox-index linux-efi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox