Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/1] efi/libstub: error message in handle_cmdline_files()
@ 2020-02-21 19:18 Heinrich Schuchardt
  2020-02-22 17:53 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2020-02-21 19:18 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: linux-efi, linux-kernel, Heinrich Schuchardt

The memory for files is allocated not reallocated.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/firmware/efi/libstub/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
index be78f64f8d80..d4c7e5f59d2c 100644
--- a/drivers/firmware/efi/libstub/file.c
+++ b/drivers/firmware/efi/libstub/file.c
@@ -190,7 +190,7 @@ static efi_status_t handle_cmdline_files(efi_loaded_image_t *image,
 							    &alloc_addr,
 							    hard_limit);
 			if (status != EFI_SUCCESS) {
-				pr_efi_err("Failed to reallocate memory for files\n");
+				pr_efi_err("Failed to allocate memory for files\n");
 				goto err_close_file;
 			}

--
2.25.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] efi/libstub: error message in handle_cmdline_files()
  2020-02-21 19:18 [PATCH 1/1] efi/libstub: error message in handle_cmdline_files() Heinrich Schuchardt
@ 2020-02-22 17:53 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-02-22 17:53 UTC (permalink / raw)
  To: Heinrich Schuchardt; +Cc: linux-efi, Linux Kernel Mailing List

On Fri, 21 Feb 2020 at 20:18, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> The memory for files is allocated not reallocated.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Queued in efi/next

Thanks,

> ---
>  drivers/firmware/efi/libstub/file.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c
> index be78f64f8d80..d4c7e5f59d2c 100644
> --- a/drivers/firmware/efi/libstub/file.c
> +++ b/drivers/firmware/efi/libstub/file.c
> @@ -190,7 +190,7 @@ static efi_status_t handle_cmdline_files(efi_loaded_image_t *image,
>                                                             &alloc_addr,
>                                                             hard_limit);
>                         if (status != EFI_SUCCESS) {
> -                               pr_efi_err("Failed to reallocate memory for files\n");
> +                               pr_efi_err("Failed to allocate memory for files\n");
>                                 goto err_close_file;
>                         }
>
> --
> 2.25.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-21 19:18 [PATCH 1/1] efi/libstub: error message in handle_cmdline_files() Heinrich Schuchardt
2020-02-22 17:53 ` Ard Biesheuvel

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git