From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A66C35666 for ; Sat, 22 Feb 2020 17:53:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 431E820707 for ; Sat, 22 Feb 2020 17:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582394019; bh=YgKrm0xiETHM9Cmfn3YsYzVL6NnGHRbjPZ0LttoOZPs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=XwzhA+wZxu2AuH3Up1nP5l5bPukCdgYDZr9cZlBYaZo5sYXccc5uGaDRsyiqYIL2e wJndujkGYVXf0W1Kzsh12owICjPuIJWDQA9xKwRSdE4EMaHc3buMfEEPBJIcVdbB8M ThEcL/yOXDXbLN9mRdD1tElKdrdWd3XKwW3NXuZw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbgBVRxi (ORCPT ); Sat, 22 Feb 2020 12:53:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:41296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbgBVRxi (ORCPT ); Sat, 22 Feb 2020 12:53:38 -0500 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70CC020707 for ; Sat, 22 Feb 2020 17:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582394017; bh=YgKrm0xiETHM9Cmfn3YsYzVL6NnGHRbjPZ0LttoOZPs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=WHBit2bA6T3EHwMhwqLDdrr2CZGcZ4tX4F/1r5Lyk9AQFzU/OqaIeMgyCzk97aE/7 O6S595fJcXq5KtBCozs3jOWCnHfAra61DJEVNImt3IcPoHBp16EPEQ+CCjyiaNIa+j 0fH3UOISh+mdmW2T186huegR4ms51t3JnWEZ/IrE= Received: by mail-wr1-f41.google.com with SMTP id t3so5586021wru.7 for ; Sat, 22 Feb 2020 09:53:37 -0800 (PST) X-Gm-Message-State: APjAAAUPA01dJHHjZV7X6aVtdCKBz7NnXkBP+7GKnUQCfaOwuaO9EEgD ygh9+oFx6ZoraGsjO9wuHldte+66kvRi+H7tUq+hlA== X-Google-Smtp-Source: APXvYqyWzaLbt4HYjpKwPlRQWQGBksiImz9hsJkpyk87ED2N2OOaMX24u0bAr90dNAd3Wc+csetD0svSTq78dij7MPk= X-Received: by 2002:a5d:5188:: with SMTP id k8mr55791430wrv.151.1582394015897; Sat, 22 Feb 2020 09:53:35 -0800 (PST) MIME-Version: 1.0 References: <20200221191829.18149-1-xypron.glpk@gmx.de> In-Reply-To: <20200221191829.18149-1-xypron.glpk@gmx.de> From: Ard Biesheuvel Date: Sat, 22 Feb 2020 18:53:25 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] efi/libstub: error message in handle_cmdline_files() To: Heinrich Schuchardt Cc: linux-efi , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, 21 Feb 2020 at 20:18, Heinrich Schuchardt wrote: > > The memory for files is allocated not reallocated. > > Signed-off-by: Heinrich Schuchardt Queued in efi/next Thanks, > --- > drivers/firmware/efi/libstub/file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/libstub/file.c b/drivers/firmware/efi/libstub/file.c > index be78f64f8d80..d4c7e5f59d2c 100644 > --- a/drivers/firmware/efi/libstub/file.c > +++ b/drivers/firmware/efi/libstub/file.c > @@ -190,7 +190,7 @@ static efi_status_t handle_cmdline_files(efi_loaded_image_t *image, > &alloc_addr, > hard_limit); > if (status != EFI_SUCCESS) { > - pr_efi_err("Failed to reallocate memory for files\n"); > + pr_efi_err("Failed to allocate memory for files\n"); > goto err_close_file; > } > > -- > 2.25.0 >