linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Matt Fleming
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	Seiji Aguchi <seiji.aguchi-7rDLJAbr9SE@public.gmane.org>,
	Geliang Tang <geliangtang-9Onoh4P/yGk@public.gmane.org>,
	"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor
Date: Thu, 18 May 2017 17:18:15 +0100	[thread overview]
Message-ID: <CAKv+Gu_Mxfgqww3T-xUmif-A=XaGbVai7nT+L1UvdO_ML3G2XQ@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5j+-WJazbLOV2n3VS6SJc8fBUqgC+AzfEVYoxYWRto5=XQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 18 May 2017 at 14:01, Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
> On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel
> <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
>> On 12 May 2017 at 22:58, Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> wrote:
>>> During the internal pstore API refactoring, the EFI vars read entry was
>>> accidentally made to update a stack variable instead of the pstore
>>> private data pointer. This corrects the problem (and removes the now
>>> needless argument).
>>>
>>> Signed-off-by: Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
>>
>> Does this need a cc stable?
>
> No, the refactor first appeared in 4.12-rc1.
>

OK. Applied.

  parent reply	other threads:[~2017-05-18 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 21:58 [PATCH] efi-pstore: Fix read iter after pstore API refactor Kees Cook
2017-05-18 10:35 ` Ard Biesheuvel
     [not found]   ` <CAKv+Gu8H7aJd0jjdMav5V+PdfM3oyh=G3hGZPZtaiXcZ2PAtQg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-18 13:01     ` Kees Cook
     [not found]       ` <CAGXu5j+-WJazbLOV2n3VS6SJc8fBUqgC+AzfEVYoxYWRto5=XQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-18 16:18         ` Ard Biesheuvel [this message]
     [not found]           ` <CAKv+Gu_Mxfgqww3T-xUmif-A=XaGbVai7nT+L1UvdO_ML3G2XQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-18 16:41             ` Kees Cook
     [not found]               ` <CAGXu5jJ0aT7-qHexqyFvDhCSJWcxUVb3zZ=-mAT=x8UtHWOVcA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-19 13:30                 ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_Mxfgqww3T-xUmif-A=XaGbVai7nT+L1UvdO_ML3G2XQ@mail.gmail.com' \
    --to=ard.biesheuvel-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
    --cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=geliangtang-9Onoh4P/yGk@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    --cc=seiji.aguchi-7rDLJAbr9SE@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).