From: Rob Herring <robh@kernel.org>
To: Gavin Shan <gshan@redhat.com>
Cc: devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"open list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)"
<kvmarm@lists.cs.columbia.edu>, Marc Zyngier <maz@kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
shan.gavin@gmail.com
Subject: Re: [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map
Date: Mon, 27 Sep 2021 09:49:30 -0500 [thread overview]
Message-ID: <CAL_JsqL8+_Q690-c3J4TS6LBF-mCUBxbhTfr994=Fwffqab0_w@mail.gmail.com> (raw)
In-Reply-To: <20210927064119.127285-3-gshan@redhat.com>
On Mon, Sep 27, 2021 at 1:42 AM Gavin Shan <gshan@redhat.com> wrote:
>
> There is no device node for the empty NUMA node. However, the
> corresponding NUMA node ID and distance map is still valid in
> "numa-distance-map-v1" compatible device node.
>
> This fetches the NUMA node ID and distance map for these empty
> NUMA node from "numa-distance-map-v1" compatible device node.
This is much nicer.
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> drivers/of/of_numa.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
> index fe6b13608e51..5949829a1b00 100644
> --- a/drivers/of/of_numa.c
> +++ b/drivers/of/of_numa.c
> @@ -111,6 +111,8 @@ static int __init of_numa_parse_distance_map_v1(struct device_node *map)
> return -EINVAL;
> }
>
> + node_set(nodea, numa_nodes_parsed);
> +
With this, couldn't we remove of_numa_parse_cpu_nodes() as the only
thing it does is node_set()?
> numa_set_distance(nodea, nodeb, distance);
>
> /* Set default distance of node B->A same as A->B */
> --
> 2.23.0
>
next prev parent reply other threads:[~2021-09-27 14:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 6:41 [PATCH v2 0/2] Specify empty NUMA node Gavin Shan
2021-09-27 6:41 ` [PATCH v2 1/2] Documentation, dt, numa: Add note to " Gavin Shan
2021-10-04 18:13 ` Rob Herring
2021-09-27 6:41 ` [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map Gavin Shan
2021-09-27 14:49 ` Rob Herring [this message]
2021-09-27 23:59 ` Gavin Shan
2021-09-28 17:22 ` Rob Herring
2021-09-29 2:00 ` Gavin Shan
2021-10-04 18:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqL8+_Q690-c3J4TS6LBF-mCUBxbhTfr994=Fwffqab0_w@mail.gmail.com' \
--to=robh@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gshan@redhat.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=rdunlap@infradead.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
--subject='Re: [PATCH v2 2/2] of, numa: Fetch empty NUMA node ID from distance map' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).