linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Benjamin Thiel <b.thiel@posteo.de>
Cc: linux-efi <linux-efi@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Borislav Petkov <bp@alien8.de>
Subject: Re: [PATCH v2] efi: Pull up arch-specific prototype efi_systab_show_arch()
Date: Sat, 16 May 2020 15:32:25 +0200	[thread overview]
Message-ID: <CAMj1kXE92_hmbaNURjW9FuRo02B9my1UBBUhPZi_CS+FRr8-aw@mail.gmail.com> (raw)
In-Reply-To: <20200516132647.14568-1-b.thiel@posteo.de>

On Sat, 16 May 2020 at 15:26, Benjamin Thiel <b.thiel@posteo.de> wrote:
>
> ... in order to fix a -Wmissing-prototypes warning:
>
> arch/x86/platform/efi/efi.c:957:7: warning: no previous prototype for
> ‘efi_systab_show_arch’ [-Wmissing-prototypes]
> char *efi_systab_show_arch(char *str)
>
> Signed-off-by: Benjamin Thiel <b.thiel@posteo.de>

Thanks, I'll queue this as a fix.

Nit: please don't treat the subject line as the first N words of the
commit log, but start with a full sentence. Not all mail readers show
the subject line and the body together. I've fixed it up for now.



> ---
>  drivers/firmware/efi/efi.c | 5 +----
>  include/linux/efi.h        | 2 ++
>  2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 911a2bd0f6b7..4e3055238f31 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -130,11 +130,8 @@ static ssize_t systab_show(struct kobject *kobj,
>         if (efi.smbios != EFI_INVALID_TABLE_ADDR)
>                 str += sprintf(str, "SMBIOS=0x%lx\n", efi.smbios);
>
> -       if (IS_ENABLED(CONFIG_IA64) || IS_ENABLED(CONFIG_X86)) {
> -               extern char *efi_systab_show_arch(char *str);
> -
> +       if (IS_ENABLED(CONFIG_IA64) || IS_ENABLED(CONFIG_X86))
>                 str = efi_systab_show_arch(str);
> -       }
>
>         return str - buf;
>  }
> diff --git a/include/linux/efi.h b/include/linux/efi.h
> index 251f1f783cdf..9430d01c0c3d 100644
> --- a/include/linux/efi.h
> +++ b/include/linux/efi.h
> @@ -1245,4 +1245,6 @@ struct linux_efi_memreserve {
>
>  void __init efi_arch_mem_reserve(phys_addr_t addr, u64 size);
>
> +char *efi_systab_show_arch(char *str);
> +
>  #endif /* _LINUX_EFI_H */
> --
> 2.20.1
>

  reply	other threads:[~2020-05-16 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-16 13:26 [PATCH v2] efi: Pull up arch-specific prototype efi_systab_show_arch() Benjamin Thiel
2020-05-16 13:32 ` Ard Biesheuvel [this message]
2020-05-16 13:37   ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXE92_hmbaNURjW9FuRo02B9my1UBBUhPZi_CS+FRr8-aw@mail.gmail.com \
    --to=ardb@kernel.org \
    --cc=b.thiel@posteo.de \
    --cc=bp@alien8.de \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).