From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D237C83000 for ; Wed, 29 Apr 2020 19:48:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33DAC2222E for ; Wed, 29 Apr 2020 19:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588189704; bh=SFR74rYP9+0171FFCb6xDPTTpNtn0bIHwSgFclfamCE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Jtlr14GFLWAKkekGFR5s7QJoLmHWAwEH4RYiMEmKw07+PIMalWfBKTOFqknKZiV4U B57EE2bmkBrfRJ/fZboUyw220XUqCYfgOVo5s154tGz2fPFgbZoc7jO2NyR1jcqE3+ +HcoUGxrlyspS2wztrs3y6Yo53eBLdsAp/4iCDkA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727896AbgD2TsU (ORCPT ); Wed, 29 Apr 2020 15:48:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:50144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727892AbgD2TsQ (ORCPT ); Wed, 29 Apr 2020 15:48:16 -0400 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 294AA22200; Wed, 29 Apr 2020 19:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588189696; bh=SFR74rYP9+0171FFCb6xDPTTpNtn0bIHwSgFclfamCE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=upV3Ifzz+cvLqIozeRKbsBvPn0Cp7d3sXcIKtqgSU1XwmqHSBGFOcdNlsURh1AEoL 5RScngGLRrgb3HZKt8vRvYNwGxnAM2X+ruEqQiP9kaLvVMJDxYHU5GyKFnlMVDRaxB 2YsqSGxVUlin2mykY+rYlCnsgnK/RzNRweIGLP54= Received: by mail-il1-f173.google.com with SMTP id s10so3621291iln.11; Wed, 29 Apr 2020 12:48:16 -0700 (PDT) X-Gm-Message-State: AGi0Pua/NxeTDHMAVXWXvJAhPXZva/tj7bOcRIDR3Ac/SOyZExKi6RQy KrfNDjigBszRNErhFvLN2JLMTZYlwkTPBQyP/FY= X-Google-Smtp-Source: APiQypJ/sJvL1QmMgGrcOxk5QdvbljU3Mk4YHsiqvrV/lveZgGlUmAgVNNWNZ76O2PEF0iLiyG7Pd986zBScJQUTLn0= X-Received: by 2002:a92:405:: with SMTP id 5mr31735312ile.279.1588189695602; Wed, 29 Apr 2020 12:48:15 -0700 (PDT) MIME-Version: 1.0 References: <20200429174120.1497212-1-nivedita@alum.mit.edu> <20200429174120.1497212-5-nivedita@alum.mit.edu> <3fa8fba37f9339adc993cdb7afc77ed0e063967d.camel@perches.com> In-Reply-To: From: Ard Biesheuvel Date: Wed, 29 Apr 2020 21:48:04 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 03/10] efi/x86: Use pr_efi_err for error messages To: Joe Perches Cc: Arvind Sankar , linux-efi , X86 ML , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Archived-At: List-Archive: List-Post: On Wed, 29 Apr 2020 at 21:47, Joe Perches wrote: > > On Wed, 2020-04-29 at 20:59 +0200, Ard Biesheuvel wrote: > > On Wed, 29 Apr 2020 at 20:57, Joe Perches wrote: > > > On Wed, 2020-04-29 at 20:49 +0200, Ard Biesheuvel wrote: > > > > On Wed, 29 Apr 2020 at 20:47, Joe Perches wrote: > > > > > Looking at code for efi_printk -> efi_char16_printk, > > > > > it's somewhat difficult to see where the "output_string" > > > > > function pointer is set. Any clue? > > > > It is set by the firmware. > > > > > > Sure, where in the code though? > > > > > > > In which code? The firmware code? > > I presume it's set from a struct received from hardware/firmware > somewhere in drivers/firmware/efi, but it doesn't seem clear where. > It is a field in the EFI system table, which we dereference directly.