From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E9FC43461 for ; Fri, 11 Sep 2020 18:17:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15303221F0 for ; Fri, 11 Sep 2020 18:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599848228; bh=u8/mPrVURYhPqdDyFTV/A2D8Sgo7S+0VEGhgujlLGjg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=apF+SIQNpxNpQRHTqxEJAZhepJ23ilmRo30Wl2Qv/7Go1A+nNAz8vug/nFuWZx3LS MMukSp2Bkhb2USLypQ7KO8hSPkt4GMNfBAiNRrPPknROtxB/CdCuoG4UAi/ur/v2xq N/CGXBhLrnf70OK6Cj7dF1eRrCUQ+bqflHvXBwr0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725851AbgIKSRH (ORCPT ); Fri, 11 Sep 2020 14:17:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:55176 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgIKSRD (ORCPT ); Fri, 11 Sep 2020 14:17:03 -0400 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4E21121D79; Fri, 11 Sep 2020 18:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599848222; bh=u8/mPrVURYhPqdDyFTV/A2D8Sgo7S+0VEGhgujlLGjg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Yw2QzwBKV1KqPoZf8Ei2GtXzn4V9U7IT3oemiHPGZmKrN1okBSsbOFZpjTqbRRRSn UWyGKJBWppRXdbU9wNH6JjNEA0KAqvoJzTkqr9Dy5/iCTqBcyhVdrTAd7JRkszq3Mm 8QubACqXP4q9KuQr2vlYn3+OrT40fdCkTSYUBKJM= Received: by mail-ot1-f53.google.com with SMTP id 60so9117216otw.3; Fri, 11 Sep 2020 11:17:02 -0700 (PDT) X-Gm-Message-State: AOAM530OWSk5puoZ5i9EwuvnYaVwUBDQk+EAlXGkwiI91mtFK6pqQDom O+VkNoDy2xp8SvmRM3kwvOIOMndlsjbrqV6CcjI= X-Google-Smtp-Source: ABdhPJwtLMTM9vEIWrzMubKwSTEJ8uvh7kjUufPCPqKEc5oc2KztzVNpmf1BlFnttv+vj/fKFZDRvMMYjoTBPJFwYa4= X-Received: by 2002:a9d:6250:: with SMTP id i16mr2081474otk.77.1599848221567; Fri, 11 Sep 2020 11:17:01 -0700 (PDT) MIME-Version: 1.0 References: <20200905013107.10457-1-lszubowi@redhat.com> <20200905013107.10457-3-lszubowi@redhat.com> <394190b9-59bd-5cb3-317e-736852f190f4@redhat.com> In-Reply-To: <394190b9-59bd-5cb3-317e-736852f190f4@redhat.com> From: Ard Biesheuvel Date: Fri, 11 Sep 2020 21:16:50 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine To: Lenny Szubowicz Cc: Mimi Zohar , Linux Kernel Mailing List , linux-efi , platform-driver-x86@vger.kernel.org, linux-security-module@vger.kernel.org, andy.shevchenko@gmail.com, James Morris , serge@hallyn.com, Kees Cook , Borislav Petkov , Peter Jones , David Howells , prarit@redhat.com Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, 11 Sep 2020 at 20:18, Lenny Szubowicz wrote: > > On 9/11/20 11:59 AM, Mimi Zohar wrote: > > On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: > >> On 9/11/20 11:02 AM, Ard Biesheuvel wrote: > >>> On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > >>>> > >>>> Move the loading of certs from the UEFI MokListRT into a separate > >>>> routine to facilitate additional MokList functionality. > >>>> > >>>> There is no visible functional change as a result of this patch. > >>>> Although the UEFI dbx certs are now loaded before the MokList certs, > >>>> they are loaded onto different key rings. So the order of the keys > >>>> on their respective key rings is the same. > >>>> > >>>> Signed-off-by: Lenny Szubowicz > >>> > >>> Why did you drop Mimi's reviewed-by from this patch? > >> > >> It was not intentional. I was just not aware that I needed to propagate > >> Mimi Zohar's reviewed-by from V1 of the patch to V2. > >> > >> Reviewed-by: Mimi Zohar > >> > >> V2 includes changes in that patch to incorporate suggestions from > >> Andy Shevchenko. My assumption was that the maintainer would > >> gather up the reviewed-by and add any signed-off-by as appropriate, > >> but it sounds like my assumption was incorrect. In retrospect, I > >> could see that having the maintainer dig through prior versions > >> of a patch set for prior reviewed-by tags could be burdensome. > > > > As much as possible moving code should be done without making changes, > > simpler for code review. Then as a separate patch you make changes. > > That way you could also have retained my Reviewed-by. > > > > Mimi > > If you or Ard think I should, I can do a V3 with: > > Patch V3 01: Unchanged from V2 > Patch V3 02: Goes back to V1 of patch 02 that Mimi reviewed > Patch V3 03: New. Has Andy's cleanup suggestions separated from patch 02 > Patch V3 04: This would most probably just be the V2 of patch 03 with no changes > I think we can just merge the patches as they are, with Mimi's R-b carried over.