* [PATCH] efi/libstub: Fix the efi_load_initrd function description
@ 2021-07-02 19:10 Atish Patra
2021-07-16 16:18 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Atish Patra @ 2021-07-02 19:10 UTC (permalink / raw)
To: linux-kernel
Cc: Atish Patra, Ard Biesheuvel, Arvind Sankar, linux-efi,
Will Deacon, Heinrich Schuchardt
The soft_limit and hard_limit in the function efi_load_initrd describes
the preferred and max address of initrd loading location respectively.
However, the description wrongly describes it as the size of the
allocated memory.
Fix the function description.
Signed-off-by: Atish Patra <atish.patra@wdc.com>
---
drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
index aa8da0a49829..ae87dded989d 100644
--- a/drivers/firmware/efi/libstub/efi-stub-helper.c
+++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
@@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
* @image: EFI loaded image protocol
* @load_addr: pointer to loaded initrd
* @load_size: size of loaded initrd
- * @soft_limit: preferred size of allocated memory for loading the initrd
- * @hard_limit: minimum size of allocated memory
+ * @soft_limit: preferred address for loading the initrd
+ * @hard_limit: upper limit address for loading the initrd
*
* Return: status code
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] efi/libstub: Fix the efi_load_initrd function description
2021-07-02 19:10 [PATCH] efi/libstub: Fix the efi_load_initrd function description Atish Patra
@ 2021-07-16 16:18 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2021-07-16 16:18 UTC (permalink / raw)
To: Atish Patra
Cc: Linux Kernel Mailing List, Arvind Sankar, linux-efi, Will Deacon,
Heinrich Schuchardt
On Fri, 2 Jul 2021 at 21:10, Atish Patra <atish.patra@wdc.com> wrote:
>
> The soft_limit and hard_limit in the function efi_load_initrd describes
> the preferred and max address of initrd loading location respectively.
> However, the description wrongly describes it as the size of the
> allocated memory.
>
> Fix the function description.
>
> Signed-off-by: Atish Patra <atish.patra@wdc.com>
Now queued up, thanks.
> ---
> drivers/firmware/efi/libstub/efi-stub-helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c
> index aa8da0a49829..ae87dded989d 100644
> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c
> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c
> @@ -630,8 +630,8 @@ efi_status_t efi_load_initrd_cmdline(efi_loaded_image_t *image,
> * @image: EFI loaded image protocol
> * @load_addr: pointer to loaded initrd
> * @load_size: size of loaded initrd
> - * @soft_limit: preferred size of allocated memory for loading the initrd
> - * @hard_limit: minimum size of allocated memory
> + * @soft_limit: preferred address for loading the initrd
> + * @hard_limit: upper limit address for loading the initrd
> *
> * Return: status code
> */
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-16 16:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 19:10 [PATCH] efi/libstub: Fix the efi_load_initrd function description Atish Patra
2021-07-16 16:18 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).