Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] efi:mokvar-table: fix build error
@ 2020-10-09  8:51 Xiaoming Ni
  2020-10-09  8:52 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Xiaoming Ni @ 2020-10-09  8:51 UTC (permalink / raw)
  To: ardb, linux-efi, linux-kernel; +Cc: nixiaoming, wangle6

drivers/firmware/efi/mokvar-table.c:139:5: error: implicit declaration of
 function 'early_memunmap'; did you mean 'devm_memunmap'?
 [-Werror=implicit-function-declaration]
drivers/firmware/efi/mokvar-table.c:148:9: error: implicit declaration of
 function 'early_memremap'; did you mean 'devm_memremap'?
 [-Werror=implicit-function-declaration]

add #include <asm/early_ioremap.h> to fix this build error

Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
---
 drivers/firmware/efi/mokvar-table.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/firmware/efi/mokvar-table.c b/drivers/firmware/efi/mokvar-table.c
index 72a9e1736fef..c23d3686f1c7 100644
--- a/drivers/firmware/efi/mokvar-table.c
+++ b/drivers/firmware/efi/mokvar-table.c
@@ -39,6 +39,7 @@
 #include <linux/kobject.h>
 #include <linux/list.h>
 #include <linux/slab.h>
+#include <asm/early_ioremap.h>
 
 /*
  * The LINUX_EFI_MOK_VARIABLE_TABLE_GUID config table is a packed
-- 
2.27.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] efi:mokvar-table: fix build error
  2020-10-09  8:51 [PATCH] efi:mokvar-table: fix build error Xiaoming Ni
@ 2020-10-09  8:52 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-10-09  8:52 UTC (permalink / raw)
  To: Xiaoming Ni; +Cc: linux-efi, Linux Kernel Mailing List, wangle6

On Fri, 9 Oct 2020 at 10:51, Xiaoming Ni <nixiaoming@huawei.com> wrote:
>
> drivers/firmware/efi/mokvar-table.c:139:5: error: implicit declaration of
>  function 'early_memunmap'; did you mean 'devm_memunmap'?
>  [-Werror=implicit-function-declaration]
> drivers/firmware/efi/mokvar-table.c:148:9: error: implicit declaration of
>  function 'early_memremap'; did you mean 'devm_memremap'?
>  [-Werror=implicit-function-declaration]
>
> add #include <asm/early_ioremap.h> to fix this build error
>
> Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>

Thank you Xiaoming. We already have a fix queued up for this issue.

> ---
>  drivers/firmware/efi/mokvar-table.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/efi/mokvar-table.c b/drivers/firmware/efi/mokvar-table.c
> index 72a9e1736fef..c23d3686f1c7 100644
> --- a/drivers/firmware/efi/mokvar-table.c
> +++ b/drivers/firmware/efi/mokvar-table.c
> @@ -39,6 +39,7 @@
>  #include <linux/kobject.h>
>  #include <linux/list.h>
>  #include <linux/slab.h>
> +#include <asm/early_ioremap.h>
>
>  /*
>   * The LINUX_EFI_MOK_VARIABLE_TABLE_GUID config table is a packed
> --
> 2.27.0
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-09  8:51 [PATCH] efi:mokvar-table: fix build error Xiaoming Ni
2020-10-09  8:52 ` Ard Biesheuvel

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git