linux-efi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Atish Patra <atish.patra@wdc.com>,
	Heinrich Schuchardt <xypron.gpk@gmx.de>,
	linux-efi <linux-efi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efi/libstub: "Exiting bootservices" message
Date: Sun, 29 Aug 2021 14:53:20 +0200	[thread overview]
Message-ID: <CAMj1kXFg30tk6pRb_QS3gNqRBsSqWAtkO=-T=7tbNVTXByrJWA@mail.gmail.com> (raw)
In-Reply-To: <20210829124955.74429-1-heinrich.schuchardt@canonical.com>

On Sun, 29 Aug 2021 at 14:50, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> The message
>
>     "Exiting boot services and installing virtual address map...\n"
>
> is even shown if we have efi=novamap on the command line or the firmware
> does not provide EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP.
>
> To avoid confusion we should print
>
>     "Exiting boot services...\n"
>
> in this case.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>

Hello Heinrich,

I agree with the analysis but I'd prefer to simply go with the shorter
string in all cases.

Thanks,
Ard.

> -
>  drivers/firmware/efi/libstub/fdt.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/libstub/fdt.c b/drivers/firmware/efi/libstub/fdt.c
> index 365c3a43a198..d871b1ac4d8b 100644
> --- a/drivers/firmware/efi/libstub/fdt.c
> +++ b/drivers/firmware/efi/libstub/fdt.c
> @@ -271,7 +271,10 @@ efi_status_t allocate_new_fdt_and_exit_boot(void *handle,
>                 return status;
>         }
>
> -       efi_info("Exiting boot services and installing virtual address map...\n");
> +       if (efi_novamap)
> +               efi_info("Exiting boot services...\n");
> +       else
> +               efi_info("Exiting boot services and installing virtual address map...\n");
>
>         map.map = &memory_map;
>         status = efi_allocate_pages(MAX_FDT_SIZE, new_fdt_addr, ULONG_MAX);
> --
> 2.30.2
>

      reply	other threads:[~2021-08-29 12:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-29 12:49 Heinrich Schuchardt
2021-08-29 12:53 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMj1kXFg30tk6pRb_QS3gNqRBsSqWAtkO=-T=7tbNVTXByrJWA@mail.gmail.com' \
    --to=ardb@kernel.org \
    --cc=atish.patra@wdc.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xypron.gpk@gmx.de \
    --subject='Re: [PATCH] efi/libstub: "Exiting bootservices" message' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).