From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B67C1C4742C for ; Wed, 4 Nov 2020 19:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 547EC206E3 for ; Wed, 4 Nov 2020 19:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604517167; bh=x8Z4vI5xusCxbaiv1HIPRu+C1+7Dtw3P0cGlUFk9NAA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=f3Xo8a7O1mtGuDV/69HhcI2gwW8uJJpYY6oSSg8uIsxLts/bJjw71Rpno8jex90nC R8vLcAwrfoaSKnGgsWffL3aC90XdHtGj63oSGiUXMG2UGXw77vT+NNkSkf0Gn5FfHQ PiCDek/Zx6LFuuuPeERXsJJS4RBMffwLb3MI3dAI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731377AbgKDTMr (ORCPT ); Wed, 4 Nov 2020 14:12:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:39808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgKDTMq (ORCPT ); Wed, 4 Nov 2020 14:12:46 -0500 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA4632080D; Wed, 4 Nov 2020 19:12:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604517165; bh=x8Z4vI5xusCxbaiv1HIPRu+C1+7Dtw3P0cGlUFk9NAA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=amq1iOZQ53SdR/nox/ircKzv/Rwc+Pug3b3dVZ/1ItwS0FZ5KuR339betQWhUYSp7 cGoGD8NrDD9Yem9Zdpt6NePnPljY5agQ3JpxPm/SYLlb36MOTtzSDwkQiUt/83k+e3 f08hLXgwDvQ/8gqK51mllN7oKipkRI28QLkrEfgQ= Received: by mail-oo1-f47.google.com with SMTP id l26so5334552oop.9; Wed, 04 Nov 2020 11:12:45 -0800 (PST) X-Gm-Message-State: AOAM532BfQLL4SA1zn3Uyo5BS8F32K38PbeoWB1SWIbH+UJiFHOsZFrF 6gmUM3VAvsLC9drSKt2Lf88mycNNV1orBJYXLok= X-Google-Smtp-Source: ABdhPJxIEicSfXra/TnAUXm7t8vezHD9GOpBWLj9M/qAj91RrOwE7DixamCjJPcC3jCGJytqI3LVl+Z5spHnaW6OICk= X-Received: by 2002:a4a:9806:: with SMTP id y6mr19928543ooi.45.1604517164848; Wed, 04 Nov 2020 11:12:44 -0800 (PST) MIME-Version: 1.0 References: <20201102223800.12181-1-ardb@kernel.org> <2fd203414ba8ac3349f0109fea633838b4e04f05.camel@linux.ibm.com> In-Reply-To: From: Ard Biesheuvel Date: Wed, 4 Nov 2020 20:12:33 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 0/3] wire up IMA secure boot for arm64 To: Mimi Zohar Cc: linux-efi , James Morris , "Serge E. Hallyn" , Dmitry Kasatkin , Catalin Marinas , Will Deacon , Chester Lin , X86 ML , "Lee, Chun-Yi" , linux-integrity , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, 4 Nov 2020 at 20:03, Mimi Zohar wrote: > > On Wed, 2020-11-04 at 19:50 +0100, Ard Biesheuvel wrote: > > On Wed, 4 Nov 2020 at 19:20, Mimi Zohar wrote: > > > > > > Hi Ard, Chester, > > > > > > On Mon, 2020-11-02 at 23:37 +0100, Ard Biesheuvel wrote: > > > > This is a follow-up to Chester's series [0] to enable IMA to the secure > > > > boot state of arm64 platforms, which is EFI based. > > > > > > > > This v4 implements the changes I suggested to Chester, in particular: > > > > - disregard MokSbState when factoring out secure boot mode discovery > > > > - turn the x86 IMA arch code into shared code for all architectures. > > > > > > > > This reduces the final patch to a one liner enabling a Kconfig option > > > > for arm64 when EFI is enabled. > > > > > > > > Build tested only. > > > > > > Thank you! This patch set is now queued in the linux-integrity next- > > > integrity-testing branch. > > > > > > > I don't mind per se, but this touches a number of different trees, > > including x86 and arm64, and nobody has acked it yet. > > > > As far as the EFI tree is concerned, it looks like I should be able to > > avoid any conflicts with other stuff that is in flight, and if not, we > > can always use your branch up until the last patch in this serires as > > a shared tag (assuming you won't rebase it). > > The next-integrity-testing branch is just a place holder waiting for > additional tags. I've reviewed and tested the patch set on x86. Based > on the secure boot status and how the kernel is configured, the > appropriate policy rules are enabled. Similarly the IMA appraise mode > (ima_appraise=) is working properly. I have not tested on arm64. > > I do not have a problem with this patch set being upstream via EFI. > Ah right. That is probably better, as EFI goes via the x86 tree, and I work closely with the arm64 maintainers on other things as well. Please let me know once you are ready to ack this from IMA pov, and I will carry it further.