From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66903C11F65 for ; Wed, 30 Jun 2021 07:30:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 431E661D06 for ; Wed, 30 Jun 2021 07:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232806AbhF3Hcy (ORCPT ); Wed, 30 Jun 2021 03:32:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:55156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232785AbhF3Hcy (ORCPT ); Wed, 30 Jun 2021 03:32:54 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E742361D0D; Wed, 30 Jun 2021 07:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625038225; bh=LgLwRlM2vgAjiWG1CvKhmKGXiZHELEvEd1+PAclEGZM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cbubElthuvDlQB1LHWO6FW8GGsopz4SX7tKIdQK0TxDO74KeBFtcx0/DPVOwyYQDN 6qb8Mtw7D4qae4jShR9NApX3uTZoOyileMkHMDufA3sHz4RGhjJ+166IMMsRbDsvcn 3pQydfyZiKTr/Uzg+22NwSIz9uVBxlJuiA1XJYcE9JOE8IOY1BPgoAs3EmS/SbGJyu rS/UpDJjN9vsTtspBOy37QpJ+j8W8XsuHa1dca/JWKB9TUIie2tB++xh+VebD6ncoZ wHWGUGbqvHFJE3vQQrLZw72st6Bo3oqY45O4hCr5tgZ4ii6ZOBc1IWF0uIvtEAVRqn qy64a4TG0mRjA== Received: by mail-oi1-f180.google.com with SMTP id h9so2016368oih.4; Wed, 30 Jun 2021 00:30:25 -0700 (PDT) X-Gm-Message-State: AOAM530wvzLu0gj2DCmN07z9bIoRZdVi8RpcCPV6jTX0wT25QsOJ66Lc JeYwF9tS5neBYGrT7UTXw7s+ytsrp3gfbV0Et8c= X-Google-Smtp-Source: ABdhPJz4vMMdAJ6JJGe6ILpvyoclvoJOW/dpZm8I2fUqYOw2PoCl+WKEED/i5LKogGBU687vnmdSi3bTOuRd7B2gAf8= X-Received: by 2002:aca:5a04:: with SMTP id o4mr24661915oib.33.1625038225214; Wed, 30 Jun 2021 00:30:25 -0700 (PDT) MIME-Version: 1.0 References: <20210629134018.62859-1-xypron.glpk@gmx.de> In-Reply-To: From: Ard Biesheuvel Date: Wed, 30 Jun 2021 09:30:14 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/1] RISC-V: load initrd wherever it fits into memory To: Atish Patra Cc: Heinrich Schuchardt , Andreas Schwab , Paul Walmsley , Palmer Dabbelt , Albert Ou , Atish Patra , linux-efi , linux-riscv , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Wed, 30 Jun 2021 at 00:56, Atish Patra wrote: > > On Tue, Jun 29, 2021 at 6:40 AM Heinrich Schuchardt wrote: > > > > Requiring that initrd is loaded below RAM start + 256 MiB led to failure > > to boot SUSE Linux with GRUB on QEMU, cf. > > https://lists.gnu.org/archive/html/grub-devel/2021-06/msg00037.html > > > > Remove the constraint. > > > > Reported-by: Andreas Schwab > > Signed-off-by: Heinrich Schuchardt > > --- > > arch/riscv/include/asm/efi.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/include/asm/efi.h b/arch/riscv/include/asm/efi.h > > index 7542282f1141..649ab513dc99 100644 > > --- a/arch/riscv/include/asm/efi.h > > +++ b/arch/riscv/include/asm/efi.h > > @@ -33,10 +33,10 @@ static inline unsigned long efi_get_max_fdt_addr(unsigned long image_addr) > > > > #define ARCH_EFI_IRQ_FLAGS_MASK (SR_IE | SR_SPIE) > > > > -/* Load initrd at enough distance from DRAM start */ > > +/* Load initrd anywhere in system RAM */ > > static inline unsigned long efi_get_max_initrd_addr(unsigned long image_addr) > > { > > - return image_addr + SZ_256M; > > + return ULONG_MAX; > > } > > > > #define alloc_screen_info(x...) (&screen_info) > > -- > > 2.30.2 > > > > LGTM > > Reviewed-by: Atish Patra > Acked-by: Ard Biesheuvel Please take this via the RISC-V tree.