From: Ard Biesheuvel <ardb@kernel.org>
To: Michael Schaller <misch@google.com>
Cc: Michael Schaller <michael@5challer.de>,
Matthew Garrett <matthew.garrett@nebula.com>,
Jeremy Kerr <jk@ozlabs.org>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] efivarfs: Replace invalid slashes with exclamation marks in dentries.
Date: Fri, 25 Sep 2020 09:55:08 +0200 [thread overview]
Message-ID: <CAMj1kXGhdtmHkcjKsSS37hXyeR3cHD3m=Qk4LZy12Nvrkz6H2A@mail.gmail.com> (raw)
In-Reply-To: <CALt099+4UNaVGoeHNOfErEtBwyUuV_ZhSRFkLKksPdWnrdednQ@mail.gmail.com>
On Fri, 25 Sep 2020 at 09:54, Michael Schaller <misch@google.com> wrote:
>
> On Fri, Sep 25, 2020 at 9:49 AM Ard Biesheuvel <ardb@kernel.org> wrote:
> >
> > On Fri, 25 Sep 2020 at 09:45, Michael Schaller <misch@google.com> wrote:
> > >
> > > Without this patch efivarfs_alloc_dentry creates dentries with slashes in
> > > their name if the respective EFI variable has slashes in its name. This in
> > > turn causes EIO on getdents64, which prevents a complete directory listing
> > > of /sys/firmware/efi/efivars/.
> > >
> > > This patch replaces the invalid shlashes with exclamation marks like
> > > kobject_set_name_vargs does for /sys/firmware/efi/vars/ to have consistently
> > > named dentries under /sys/firmware/efi/vars/ and /sys/firmware/efi/efivars/.
> > >
> > > Signed-off-by: Michael Schaller <misch@google.com>
> >
> > Thanks
> >
> > > Tested-by: Michael Schaller <misch@google.com>
> >
> > I will drop this - in general, it is assumed that you test your own
> > patches before sending them to the list, so this is implicit. Also,
> > tested-by's given on the list tend to carry more weight than ones that
> > are givenin private and added to the patch by the authors themselves.
> >
> Makes sense. Is anything else needed from my side?
No, all good. I'll pick this up as a fix.
next prev parent reply other threads:[~2020-09-25 7:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 7:45 [PATCH v2] efivarfs: Replace invalid slashes with exclamation marks in dentries Michael Schaller
2020-09-25 7:48 ` Ard Biesheuvel
2020-09-25 7:54 ` Michael Schaller
2020-09-25 7:55 ` Ard Biesheuvel [this message]
2020-09-25 7:58 ` Michael Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMj1kXGhdtmHkcjKsSS37hXyeR3cHD3m=Qk4LZy12Nvrkz6H2A@mail.gmail.com' \
--to=ardb@kernel.org \
--cc=jk@ozlabs.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=michael@5challer.de \
--cc=misch@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).