From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C3BC4360C for ; Thu, 10 Oct 2019 18:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F22C2053B for ; Thu, 10 Oct 2019 18:50:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbfJJSu6 (ORCPT ); Thu, 10 Oct 2019 14:50:58 -0400 Received: from mail-oi1-f196.google.com ([209.85.167.196]:44285 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbfJJSu6 (ORCPT ); Thu, 10 Oct 2019 14:50:58 -0400 Received: by mail-oi1-f196.google.com with SMTP id w6so5808654oie.11; Thu, 10 Oct 2019 11:50:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pe9UtS2nB3IVlBbTVZ3hO/YsOnzfUIPDBvq3veYk6Pg=; b=kx1OW3fFfVDe/l3mHLjQOWgaEBP+jrlLuvk24StYiZMhfPIOGBXlbC5Z0Lu5I2ZOen GXfRad53Wa+dEclrWfWtGsvokTsmw/mg0GuVBnf0osci4swUorj3I2+s6MNQ6zdDSaVt 1eyrkcx/KAdrZbuv0MYdw6EvZx6d0T0UvJr/WVRhOEZqK8lVYh0dxRrkfzjICsP3p6gM gxGvVLqszAof4lxhVG5uRDyPXi7nFbHmvi/Qc6Qpnp2VxTW8YVMCElVg/hWxc/56cxfY abac6XJN3HT2BHfuwyKFYJff3fnfSFezS7VQR1h8E+0P422t/iIF3YSUIcydkmHClMhT iqnQ== X-Gm-Message-State: APjAAAWiRsCFPlj9hoU9jOUnZCUcsC9hhcY71aattfbRiCDY+DBWaWUn fb0Pr2ZVJ+swT/lHdCslDSM2z6SUFHZBPjffVN8FXWnZ X-Google-Smtp-Source: APXvYqxHBnRYVznAMgmZqD4x3EvzZXk8DCBb1p7eqY2OJrA8SaFoMCgRJz6m1m2/1M3jlyYoLP5l6HXOT/RSdtNr0f4= X-Received: by 2002:a54:4e89:: with SMTP id c9mr8518987oiy.148.1570733457084; Thu, 10 Oct 2019 11:50:57 -0700 (PDT) MIME-Version: 1.0 References: <20191002194346.GA3792@localhost.localdomain> <20191010174710.GA2405@localhost.localdomain> In-Reply-To: <20191010174710.GA2405@localhost.localdomain> From: Geert Uytterhoeven Date: Thu, 10 Oct 2019 20:50:45 +0200 Message-ID: Subject: Re: [PATCH] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y To: Narendra K Cc: Ard Biesheuvel , linux-efi , Mario Limonciello , Thomas Gleixner , Linux Kernel Mailing List , James Morse , Ingo Molnar Content-Type: text/plain; charset="UTF-8" Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Hi Narendra, On Thu, Oct 10, 2019 at 7:47 PM wrote: > On Wed, Oct 09, 2019 at 04:11:04PM +0200, Ard Biesheuvel wrote: > > On Wed, 2 Oct 2019 at 21:44, wrote: > > > > > > From: Narendra K > > > > > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user > > > for input as it is a new kconfig option in kernel version 5.4. This patch > > > modifies the kconfig option to ask the user for input only when CONFIG_X86 > > > or CONFIG_COMPILE_TEST is set to y. > > > > > > The patch also makes EFI_RCI2_TABLE kconfig option depend on CONFIG_EFI. > > > > > > Signed-off-by: Narendra K > > > drivers/firmware/efi/Kconfig | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig > > > index 178ee8106828..6e4c46e8a954 100644 > > > --- a/drivers/firmware/efi/Kconfig > > > +++ b/drivers/firmware/efi/Kconfig > > > @@ -181,7 +181,10 @@ config RESET_ATTACK_MITIGATION > > > reboots. > > > > > > config EFI_RCI2_TABLE > > > - bool "EFI Runtime Configuration Interface Table Version 2 Support" > > > + bool > > > + prompt "EFI RCI Table Version 2 Support" if X86 || COMPILE_TEST Why the split of bool and prompt? Why not simply add a single line "depends on X86 || COMPILE_TEST"? > > > > You can drop the || COMPILE_TEST as well. > > I will drop this part of the change in the next version of the patch. Why drop that part? Isn't it good to have more compile test coverage? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds