From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA087C0044D for ; Mon, 16 Mar 2020 09:18:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8CEFD20674 for ; Mon, 16 Mar 2020 09:18:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=endlessm-com.20150623.gappssmtp.com header.i=@endlessm-com.20150623.gappssmtp.com header.b="xnDXV/hx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730393AbgCPJSh (ORCPT ); Mon, 16 Mar 2020 05:18:37 -0400 Received: from mail-vk1-f196.google.com ([209.85.221.196]:43456 "EHLO mail-vk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730356AbgCPJSh (ORCPT ); Mon, 16 Mar 2020 05:18:37 -0400 Received: by mail-vk1-f196.google.com with SMTP id t3so4632552vkm.10 for ; Mon, 16 Mar 2020 02:18:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=endlessm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xS1w6b9dGNxOYZgn4XqIsKqMFqWDeiCDvqlu4Cc2qb8=; b=xnDXV/hxwqGt009+I3FBwB8fLLhBVcO6v21MqAzIxBgCZ2q9ZUfSnVGKHDpIwcNUQX hajdIKjDWiM9wPD4n9GCOk3b6y5IcSF092I0S8x6fJGvW+sH42iV/J6WHM9tt+C7vEZF jl4oZ168qMMXgOXkw/govVYYtLVFcfaj7zpfmsnGvZRBTKj2u6j9B5mHyLqsYOMXkYFF JTZkazg1IZX9qDjyFtVdg/LZZ3snSKEHxReNjHW4pvikHuHLuBDckOwvR1nCSf6YvmgE zeXnBophhXqLmdmjTJWHkz93QXPukqVYXYyRZL5gFFM4sGb4e3pMhz8WegZ6w0EBSkV1 uvjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xS1w6b9dGNxOYZgn4XqIsKqMFqWDeiCDvqlu4Cc2qb8=; b=Bovaurpapiur33paXDxNLDvU1Vb8sO3IwXu5cpRCH1OiWQTkYGFw/Mzz45t3/XX1Y/ eNG0TsfpOAeceIcpMW+T0b4qOguqltC3fI9j7K6Cx+9vfU7nrCSgxmiJBROYuZgqK4Cn bB2xEbqWULFy7zlYd1Q5eA5NYSNY7oV9bn+CtZV4xViPDFkqEdUkllM57lqsjREQm2bh uWO3Lmg+uSog9gz5wiYIW5RhJshMyYD4LVj2bl2VcLoMOlwww77YS8GHy8pUByMdosvd X4za1cQH8ba+beCSclbdsQHM9w/G9t/5T8Jp6QmxjOBxz+amg/gJM5esylRHbLS8WoKX 9JZA== X-Gm-Message-State: ANhLgQ07qWbk39SOxxrInie1vcXTmeYU/PrVSXi4c+pWr2mHL9BkSSiJ KegLU4oLl73b0Z4NWKqcX4LXQs3hd06djUVyE2l0nA== X-Google-Smtp-Source: ADFU+vu26XRxSxwCaT6vnRCiejRxHsSjxolFEGSMIeKbwDFbcaLA927cijTLnlzzA4QRtWQr/dvD7OnuZmcs91NIUaA= X-Received: by 2002:a1f:a286:: with SMTP id l128mr15786621vke.31.1584350313783; Mon, 16 Mar 2020 02:18:33 -0700 (PDT) MIME-Version: 1.0 References: <20200312083341.9365-1-jian-hong@endlessm.com> <20200312104643.GA15619@zn.tnic> In-Reply-To: <20200312104643.GA15619@zn.tnic> From: Jian-Hong Pan Date: Mon, 16 Mar 2020 17:17:56 +0800 Message-ID: Subject: Re: [PATCH] Revert "x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T" To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Ard Biesheuvel , Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , x86@kernel.org, Linux Kernel , linux-efi@vger.kernel.org, Linux Upstreaming Team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Borislav Petkov =E6=96=BC 2020=E5=B9=B43=E6=9C=8812=E6=97=A5= =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=886:46=E5=AF=AB=E9=81=93=EF=BC=9A > > On Thu, Mar 12, 2020 at 04:33:42PM +0800, Jian-Hong Pan wrote: > > This reverts commit 0082517fa4bce073e7cf542633439f26538a14cc. > > > > According to Acer's information, this reboot issue is fixed since 1.08 > > and newer BIOS. So, we can revert the quirk. > > We can? > > How do you know *everyone* affected will update their BIOS? > > And what's the downside of keeping it? Good question! How about add DMI_BIOS_VERSION for BIOS DMI_MATCH. For example, DMI_MATCH(DMI_BIOS_VERSION, "V1.0") The BIOS versions listed on Acer website [1] are 1.04, 1.10 ... The reboot issue is fixed since BIOS 1.08. So, the only the string like "V1.0*" should apply the quirk. But, that will raise another question: Since the original quirk works for all Acer X514-51T and the quirk cannot be removed for older BIOS. Why not keep only original matching items for all Acer X514-51T laptops? I am not sure which option is better. Any comment? [1] https://www.acer.com/ac/en/US/content/support-product/7889?b=3D1 BR, Jian-Hong Pan