From: Michael Kelley <mikelley@microsoft.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Marc Zyngier <maz@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
gregkh <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
linux-arch <linux-arch@vger.kernel.org>,
"olaf@aepfle.de" <olaf@aepfle.de>,
Andy Whitcroft <apw@canonical.com>,
vkuznets <vkuznets@redhat.com>, Jason Wang <jasowang@redhat.com>,
"marcelo.cerri@canonical.com" <marcelo.cerri@canonical.com>,
KY Srinivasan <kys@microsoft.com>,
Sunil Muthuswamy <sunilmut@microsoft.com>,
Boqun Feng <boqun.feng@gmail.com>
Subject: RE: [PATCH v6 05/10] arm64: hyperv: Add interrupt handlers for VMbus and stimer
Date: Wed, 18 Mar 2020 00:16:24 +0000 [thread overview]
Message-ID: <MW2PR2101MB1052B9C24DAB19FBBD818347D7F70@MW2PR2101MB1052.namprd21.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a2yve3R1w5igBYMy3HSFJ8Xt4BHhXQcaTAkNCdZXZ1v-w@mail.gmail.com>
From: Arnd Bergmann <arnd@arndb.de>
>
> On Sat, Mar 14, 2020 at 4:36 PM Michael Kelley <mikelley@microsoft.com> wrote:
> >
> > Add ARM64-specific code to set up and handle the interrupts
> > generated by Hyper-V for VMbus messages and for stimer expiration.
> >
> > This code is architecture dependent and is mostly driven by
> > architecture independent code in the VMbus driver and the
> > Hyper-V timer clocksource driver.
> >
> > This code is built only when CONFIG_HYPERV is enabled.
> >
> > Signed-off-by: Michael Kelley <mikelley@microsoft.com>
>
> This looks like it should be a nested irqchip driver instead, so your
> device drivers can use the normal request_irq() functions etc.
>
> Is anything preventing you from doing that? If so, please describe
> that in the changelog and in a comment in the driver.
>
As mentioned in my reply on Patch 1, Hyper-V offers a limited synthetic
interrupt controller managed by Linux code that's been around the last
10 years on the x86 side. For reasons that pre-date me, it was not written
as an irqchip driver.
Modulo the small routines you see in this patch, the code is architecture
independent, and it seems we ought to keep the high degree of commonality.
Re-architecting the arch independent code to model as an irqchip driver seems
to carry some risk to the x86 side that has a lot of real-world usage today, but
I'll take a look and see what the risks look like and if it adds any clarity.
next prev parent reply other threads:[~2020-03-18 0:16 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 15:35 [PATCH v6 00/10] Subject: Enable Linux guests on Hyper-V on ARM64 Michael Kelley
2020-03-14 15:35 ` [PATCH v6 01/10] arm64: hyperv: Add core Hyper-V include files Michael Kelley
2020-03-15 17:31 ` Marc Zyngier
2020-03-18 0:10 ` Michael Kelley
2020-03-16 8:47 ` Arnd Bergmann
2020-03-18 0:12 ` Michael Kelley
2020-03-18 10:10 ` Arnd Bergmann
2020-03-19 21:31 ` Michael Kelley
2020-03-20 16:38 ` Arnd Bergmann
2020-03-14 15:35 ` [PATCH v6 02/10] arm/arm64: smccc-1.1: Add vendor specific owner definition Michael Kelley
2020-03-14 15:35 ` [PATCH v6 03/10] arm64: hyperv: Add hypercall and register access functions Michael Kelley
2020-03-14 15:35 ` [PATCH v6 04/10] arm64: hyperv: Add memory alloc/free functions for Hyper-V size pages Michael Kelley
2020-03-16 8:22 ` Arnd Bergmann
2020-03-16 8:30 ` gregkh
2020-03-16 8:30 ` Marc Zyngier
2020-03-16 8:32 ` Arnd Bergmann
2020-03-18 0:15 ` Michael Kelley
2020-03-18 9:57 ` Arnd Bergmann
2020-03-19 21:43 ` Michael Kelley
2020-03-20 16:28 ` Arnd Bergmann
2020-03-20 17:22 ` Michael Kelley
2020-03-14 15:35 ` [PATCH v6 05/10] arm64: hyperv: Add interrupt handlers for VMbus and stimer Michael Kelley
2020-03-16 8:25 ` Arnd Bergmann
2020-03-18 0:16 ` Michael Kelley [this message]
2020-03-18 9:52 ` Arnd Bergmann
2020-03-14 15:35 ` [PATCH v6 06/10] arm64: hyperv: Add kexec and panic handlers Michael Kelley
2020-03-15 18:15 ` Marc Zyngier
2020-03-18 0:17 ` Michael Kelley
2020-03-14 15:35 ` [PATCH v6 07/10] arm64: hyperv: Initialize hypervisor on boot Michael Kelley
2020-03-16 8:29 ` Arnd Bergmann
2020-03-18 0:17 ` Michael Kelley
2020-03-18 9:44 ` Arnd Bergmann
2020-03-14 15:35 ` [PATCH v6 08/10] Drivers: hv: vmbus: Add hooks for per-CPU IRQ Michael Kelley
2020-03-14 15:35 ` [PATCH v6 09/10] arm64: efi: Export screen_info Michael Kelley
2020-03-16 8:20 ` Arnd Bergmann
2020-03-18 0:18 ` Michael Kelley
2020-03-18 9:26 ` Arnd Bergmann
2020-03-19 21:46 ` Michael Kelley
2020-05-13 14:26 ` Nikhil Mahale
2020-05-18 4:25 ` Nikhil Mahale
2020-05-18 12:51 ` Ard Biesheuvel
2020-05-22 11:14 ` Nikhil Mahale
2020-05-22 11:32 ` Ard Biesheuvel
2020-03-14 15:35 ` [PATCH v6 10/10] Drivers: hv: Enable Hyper-V code to be built on ARM64 Michael Kelley
[not found] ` <20200318031130.5476-1-hdanton@sina.com>
2020-03-19 21:04 ` [PATCH v6 03/10] arm64: hyperv: Add hypercall and register access functions Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW2PR2101MB1052B9C24DAB19FBBD818347D7F70@MW2PR2101MB1052.namprd21.prod.outlook.com \
--to=mikelley@microsoft.com \
--cc=apw@canonical.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=olaf@aepfle.de \
--cc=sunilmut@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).