Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: Oleksandr Natalenko <oleksandr@natalenko.name>,
	linux-efi <linux-efi@vger.kernel.org>,
	Jeremy Kerr <jk@ozlabs.org>, Matthew Garrett <mjg59@google.com>,
	David Laight <David.Laight@aculab.com>,
	Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>,
	"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH] efivarfs: revert "fix memory leak in efivarfs_create()"
Date: Wed, 25 Nov 2020 09:25:41 +0100
Message-ID: <X74VBej49SCPVisA@kroah.com> (raw)
In-Reply-To: <CAMj1kXG0D7H=A=2DjjNxqHRC26dhWR2c-i3b2Enc4sLoYgFbJQ@mail.gmail.com>

On Wed, Nov 25, 2020 at 09:05:42AM +0100, Ard Biesheuvel wrote:
> On Wed, 25 Nov 2020 at 09:05, Oleksandr Natalenko
> <oleksandr@natalenko.name> wrote:
> >
> > Hello.
> >
> > On 25.11.2020 08:53, Ard Biesheuvel wrote:
> > > The memory leak addressed by commit fe5186cf12e3 is a false positive:
> > > all allocations are recorded in a linked list, and freed when the
> > > filesystem is unmounted. This leads to double frees, and as reported
> > > by David, leads to crashes if SLUB is configured to self destruct when
> > > double frees occur.
> > >
> > > So drop the redundant kfree() again, and instead, mark the offending
> > > pointer variable so the allocation is ignored by kmemleak.
> > >
> > > Cc: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
> >
> > Should also have:
> >
> > Cc: <stable@vger.kernel.org> # v5.9
> >
> 
> No it should not. The fixes tag should be sufficient.

No, "Fixes:" does not ever mean "I want this patch to go to a stable
tree".  It might happen, it might not, if you REALLY know this should go
to a stable tree, please follow the directions for what we have been
doing for 15+ years now, as documented in:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Hint, use "cc: stable@vger.kernel.org" if you know you want it applied,
otherwise it's just a best-guess-effort on our part.

thanks,

greg k-h

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  7:53 Ard Biesheuvel
2020-11-25  8:05 ` Oleksandr Natalenko
2020-11-25  8:05   ` Ard Biesheuvel
2020-11-25  8:25     ` Greg Kroah-Hartman [this message]
2020-11-25 10:27 ` Oleksandr Natalenko
2020-11-25 10:28   ` Ard Biesheuvel
2020-11-27 16:50     ` Jonathon Fernyhough
2020-11-27 16:58       ` Ard Biesheuvel
2020-11-27 16:59       ` Oleksandr Natalenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X74VBej49SCPVisA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=David.Laight@aculab.com \
    --cc=ardb@kernel.org \
    --cc=jk@ozlabs.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=mjg59@google.com \
    --cc=oleksandr@natalenko.name \
    --cc=stable@vger.kernel.org \
    --cc=vamshi.k.sthambamkadi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org
	public-inbox-index linux-efi

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git