From: "Michał Mirosław" <firstname.lastname@example.org> To: Dmitry Osipenko <email@example.com> Cc: Jens Axboe <firstname.lastname@example.org>, Thierry Reding <email@example.com>, Jonathan Hunter <firstname.lastname@example.org>, David Heidelberg <email@example.com>, Peter Geis <firstname.lastname@example.org>, Ulf Hansson <email@example.com>, Adrian Hunter <firstname.lastname@example.org>, Christoph Hellwig <email@example.com>, Davidlohr Bueso <firstname.lastname@example.org>, Rob Herring <email@example.com>, Ion Agorria <AG0RRIA@yahoo.com>, Svyatoslav Ryhel <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, linux-efi <email@example.com> Subject: Re: [PATCH v6 0/5] Support EFI partition on NVIDIA Tegra devices Date: Tue, 24 Aug 2021 19:03:36 +0200 [thread overview] Message-ID: <YSUmaAiRx1Q4eEcfirstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> On Tue, Aug 24, 2021 at 07:06:18PM +0300, Dmitry Osipenko wrote: > 24.08.2021 13:38, Michał Mirosław пишет: > > On Tue, Aug 24, 2021 at 01:40:02AM +0200, Michał Mirosław wrote: > >> On Sat, Aug 21, 2021 at 08:27:15PM +0300, Dmitry Osipenko wrote: > >>> 21.08.2021 01:41, Michał Mirosław пишет: > >>>> On Thu, Aug 19, 2021 at 01:19:15AM +0300, Dmitry Osipenko wrote: > >>>>> This series adds the most minimal EFI partition support for NVIDIA Tegra > >>>>> consumer devices, like Android tablets and game consoles, making theirs > >>>>> eMMC accessible out-of-the-box using downstream bootloader and mainline > >>>>> Linux kernel. eMMC now works on Acer A500 tablet and Ouya game console > >>>>> that are already well supported in mainline and internal storage is the > >>>>> only biggest thing left to support. > >>>> [...] > >>>> > >>>> Could we provide the GPT sector via DT? As I understand this is for > >>>> non-removable eMMC storage. It would remove the need for a cap bit and > >>>> hardcoded calculations instead just checking if DT node of the controller > >>>> contains a magic entry with a number. > >>> > >>> The same device model usually comes in different flavors that have a > >>> different eMMC unit and size. So no, it can't be hardcoded in DT. > >> > >> I see. I was thinking how to avoid of going the whole way and creating > >> another controller capability (since this is going to be core code) - > >> could this workaround be enabled just by a boolean DT property at > >> controller's node instead? Or do we expect non-DT platforms to be > >> similarly broken? > > > > Rewording my concern: I believe that this is platform's and not > > a controller's misfeature, so the controller driver feels like wrong > > place fix. That's why I'd prefer that the enable came from the DT > > and not from driver's code. > > The alternative GPT entry requires user to add 'gpt' argument to > kernel's cmdline. If board already uses proper alternative GPT entry at > the last sector, then nothing changed for that board. > > The case where board uses 'gpt' cmdline + it had stale GPT entry at the > special location used by Android devices and chance that now suddenly > that GPT entry will pop up is close to zero. > > All old partition table entries should be erased on reparation. If it > wasn't done, then it's not a kernel's problem, it's much more a user's > problem. Even though kernel could help that poor user if will be really > needed. > > There is no reason to over-engineer unless somebody will tell that it > broke the very special board. Neither of currently supported boards > should require more quirks. Hence, why bother? You could drop patch 4 from v7 if you checked DT boolean property instead of adding a capability in patch 3. (Patch 4 would be replaced by DT changes for relevant boards.) Best Regards Michał Mirosław
prev parent reply other threads:[~2021-08-24 17:05 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-18 22:19 Dmitry Osipenko 2021-08-18 22:19 ` [PATCH v6 1/5] block: Add alternative_gpt_sector() operation Dmitry Osipenko 2021-08-19 7:08 ` Christoph Hellwig 2021-08-18 22:19 ` [PATCH v6 2/5] partitions/efi: Support non-standard GPT location Dmitry Osipenko 2021-08-19 7:11 ` Christoph Hellwig 2021-08-19 15:17 ` Davidlohr Bueso 2021-08-20 22:45 ` Michał Mirosław 2021-08-21 17:26 ` Dmitry Osipenko 2021-08-18 22:19 ` [PATCH v6 3/5] mmc: core: Add raw_boot_mult field to mmc_ext_csd Dmitry Osipenko 2021-08-18 22:19 ` [PATCH v6 4/5] mmc: block: Support alternative_gpt_sector() operation Dmitry Osipenko 2021-08-18 22:19 ` [PATCH v6 5/5] mmc: sdhci-tegra: Enable MMC_CAP2_ALT_GPT_SECTOR Dmitry Osipenko 2021-08-19 17:18 ` [PATCH v6 0/5] Support EFI partition on NVIDIA Tegra devices Davidlohr Bueso 2021-08-19 22:27 ` Dmitry Osipenko 2021-08-20 22:41 ` Michał Mirosław 2021-08-21 17:27 ` Dmitry Osipenko 2021-08-23 23:40 ` Michał Mirosław 2021-08-24 10:38 ` Michał Mirosław 2021-08-24 16:06 ` Dmitry Osipenko 2021-08-24 17:03 ` Michał Mirosław [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YSUmaAiRx1Q4eEcfirstname.lastname@example.org \ --email@example.com \ --cc=AG0RRIA@yahoo.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v6 0/5] Support EFI partition on NVIDIA Tegra devices' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).