From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A38C433F5 for ; Mon, 11 Oct 2021 08:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3816F60F38 for ; Mon, 11 Oct 2021 08:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235282AbhJKIuf (ORCPT ); Mon, 11 Oct 2021 04:50:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235276AbhJKIue (ORCPT ); Mon, 11 Oct 2021 04:50:34 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E9294C061570; Mon, 11 Oct 2021 01:48:34 -0700 (PDT) Received: from zn.tnic (p200300ec2f08bb008041f0293f2a9501.dip0.t-ipconnect.de [IPv6:2003:ec:2f08:bb00:8041:f029:3f2a:9501]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 8ED011EC01CE; Mon, 11 Oct 2021 10:48:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1633942112; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=WX7Mv16IItiWUhDYtgsQ58XhYcnYoY2/nQSVZ23QgEg=; b=Ue70iMsndjsy737r0a//5qQ1NU65dolZ0oHJYGSTMEMzKT3itfDJfBtMRSqYuWrKViHFS3 2eZO2GQS2SA1qZ6pyQ0CvE9ttnnQNX3/j6ygLUtSzi8mRTaSJD9CRoohuRLpaGHYGxN4Xf nQqfHtGyOog15JWmfroRpy+iRXtWPqk= Date: Mon, 11 Oct 2021 10:48:28 +0200 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, Borislav Petkov Subject: Re: [PATCH v6 03/42] x86/sev: Get rid of excessive use of defines Message-ID: References: <20211008180453.462291-1-brijesh.singh@amd.com> <20211008180453.462291-4-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211008180453.462291-4-brijesh.singh@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Fri, Oct 08, 2021 at 01:04:14PM -0500, Brijesh Singh wrote: > From: Borislav Petkov > > Remove all the defines of masks and bit positions for the GHCB MSR > protocol and use comments instead which correspond directly to the spec > so that following those can be a lot easier and straightforward with the > spec opened in parallel to the code. > > Aligh vertically while at it. > > No functional changes. > > Signed-off-by: Borislav Petkov When you handle someone else's patch, you need to add your SOB underneath to state that fact. I'll add it now but don't forget rule as it is important to be able to show how a patch found its way upstream. Like you've done for the next patch. :) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette