From: Chen Yu <yu.c.chen@intel.com>
To: <linux-efi@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Nikolay Borisov <nik.borisov@suse.com>,
Chao Gao <chao.gao@intel.com>, <linux-kernel@vger.kernel.org>,
"Hossain, Md Iqbal" <md.iqbal.hossain@intel.com>
Subject: Re: [PATCH v2] efi/unaccepted: touch soft lockup during memory accept
Date: Mon, 22 Apr 2024 22:40:09 +0800 [thread overview]
Message-ID: <ZiZ2yUI09QIrYr/4@chenyu5-mobl2> (raw)
In-Reply-To: <20240411004907.649394-1-yu.c.chen@intel.com>
On 2024-04-11 at 08:49:07 +0800, Chen Yu wrote:
> Commit 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused
> by parallel memory acceptance") has released the spinlock so
> other CPUs can do memory acceptance in parallel and not
> triggers softlockup on other CPUs.
>
> However the softlock up was intermittent shown up if the memory
> of the TD guest is large, and the timeout of softlockup is set
> to 1 second.
>
> The symptom is:
> When the local irq is enabled at the end of accept_memory(),
> the softlockup detects that the watchdog on single CPU has
> not been fed for a while. That is to say, even other CPUs
> will not be blocked by spinlock, the current CPU might be
> stunk with local irq disabled for a while, which hurts not
> only nmi watchdog but also softlockup.
>
> Chao Gao pointed out that the memory accept could be time
> costly and there was similar report before. Thus to avoid
> any softlocup detection during this stage, give the
> softlockup a flag to skip the timeout check at the end of
> accept_memory(), by invoking touch_softlockup_watchdog().
>
> Fixes: 50e782a86c98 ("efi/unaccepted: Fix soft lockups caused by parallel memory acceptance")
> Reported-by: "Hossain, Md Iqbal" <md.iqbal.hossain@intel.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> ---
> v1 -> v2:
> Refine the commit log and add fixes tag/reviewed-by tag from Kirill.
Gently pinging about this patch.
thanks,
Chenyu
next prev parent reply other threads:[~2024-04-22 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 0:49 [PATCH v2] efi/unaccepted: touch soft lockup during memory accept Chen Yu
2024-04-22 14:40 ` Chen Yu [this message]
2024-04-24 17:12 ` Ard Biesheuvel
2024-05-03 10:31 ` Ard Biesheuvel
2024-05-03 13:47 ` Kirill A. Shutemov
2024-05-03 15:00 ` Chen Yu
2024-05-06 9:24 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZiZ2yUI09QIrYr/4@chenyu5-mobl2 \
--to=yu.c.chen@intel.com \
--cc=ardb@kernel.org \
--cc=chao.gao@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md.iqbal.hossain@intel.com \
--cc=nik.borisov@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).