From: Thomas Zimmermann <tzimmermann@suse.de>
To: Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-efi@vger.kernel.org, dri-devel@lists.freedesktop.org,
Javier Martinez Canillas <javierm@redhat.com>,
Mark Brown <broonie@kernel.org>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] efi: sysfb_efi: fix build when EFI is not set
Date: Tue, 27 Jul 2021 11:15:36 +0200 [thread overview]
Message-ID: <aefba212-1e08-9994-6d6e-6db292bf9db6@suse.de> (raw)
In-Reply-To: <20210727050447.7339-1-rdunlap@infradead.org>
[-- Attachment #1.1: Type: text/plain, Size: 2989 bytes --]
Hi
Am 27.07.21 um 07:04 schrieb Randy Dunlap:
> When # CONFIG_EFI is not set, there are 2 definitions of
> sysfb_apply_efi_quirks(). The stub from sysfb.h should be used
> and the __init function from sysfb_efi.c should not be used.
>
> ../drivers/firmware/efi/sysfb_efi.c:337:13: error: redefinition of ‘sysfb_apply_efi_quirks’
> __init void sysfb_apply_efi_quirks(struct platform_device *pd)
> ^~~~~~~~~~~~~~~~~~~~~~
> In file included from ../drivers/firmware/efi/sysfb_efi.c:26:0:
> ../include/linux/sysfb.h:65:20: note: previous definition of ‘sysfb_apply_efi_quirks’ was here
> static inline void sysfb_apply_efi_quirks(struct platform_device *pd)
> ^~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: linux-efi@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: linux-next@vger.kernel.org
Thanks for the patch. It should have a fixes line
> dim fixes 8633ef82f101c040427b57d4df7b706261420b94
Fixes: 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer
setup for all arches")
... and maybe a few more of the CCs below
Cc: Javier Martinez Canillas <javierm@redhat.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Nicolas Saenz Julienne <nsaenz@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: linux-efi@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
Best regards
Thomas
> ---
> drivers/firmware/efi/sysfb_efi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linext-20210726.orig/drivers/firmware/efi/sysfb_efi.c
> +++ linext-20210726/drivers/firmware/efi/sysfb_efi.c
> @@ -332,6 +332,7 @@ static const struct fwnode_operations ef
> .add_links = efifb_add_links,
> };
>
> +#ifdef CONFIG_EFI
> static struct fwnode_handle efifb_fwnode;
>
> __init void sysfb_apply_efi_quirks(struct platform_device *pd)
> @@ -354,3 +355,4 @@ __init void sysfb_apply_efi_quirks(struc
> pd->dev.fwnode = &efifb_fwnode;
> }
> }
> +#endif
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
next prev parent reply other threads:[~2021-07-27 9:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 5:04 [PATCH] efi: sysfb_efi: fix build when EFI is not set Randy Dunlap
2021-07-27 7:05 ` Ard Biesheuvel
2021-07-27 7:54 ` Javier Martinez Canillas
2021-07-27 9:15 ` Thomas Zimmermann [this message]
2021-07-27 9:54 ` Daniel Vetter
2021-07-27 16:25 ` kernel test robot
2021-07-28 8:39 ` Geert Uytterhoeven
2021-07-28 8:50 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aefba212-1e08-9994-6d6e-6db292bf9db6@suse.de \
--to=tzimmermann@suse.de \
--cc=ardb@kernel.org \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).