Linux-EFI Archive on lore.kernel.org
 help / color / Atom feed
* Boot regression in 4.8 for Mac Pro server
@ 2019-09-11 20:42 Scott Talbert
  2019-09-11 23:17 ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: Scott Talbert @ 2019-09-11 20:42 UTC (permalink / raw)
  To: linux-efi

Hi,

I just recently discovered a boot regression that occurred starting in 4.8 
on a Mac Pro Mid-2012 server (MacPro5,1).  Yes, I realize this problem is 
over 3 years old.  Obviously, I haven't been using Linux on this hardware 
in a while.  :-)  I bisected the regression to 
475fb4e8b2f4444d1d7b406ff3a7d21bc89a1e6f "efi / ACPI: load SSTDs from EFI 
variables".  And indeed, v5.3-rc7 will boot if I comment out the 
efivar_ssdt_load() call, as in:

$ git diff
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index ad3b1f4866b3..691a8671a2ba 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -364,8 +364,8 @@ static int __init efisubsys_init(void)
         if (error)
                 goto err_put;

-       if (efi_enabled(EFI_RUNTIME_SERVICES))
-               efivar_ssdt_load();
+       //if (efi_enabled(EFI_RUNTIME_SERVICES))
+       //      efivar_ssdt_load();

         error = sysfs_create_group(efi_kobj, &efi_subsys_attr_group);
         if (error) {


Any thoughts on how to fix this?

Thanks,
Scott

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Boot regression in 4.8 for Mac Pro server
  2019-09-11 20:42 Boot regression in 4.8 for Mac Pro server Scott Talbert
@ 2019-09-11 23:17 ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2019-09-11 23:17 UTC (permalink / raw)
  To: Scott Talbert; +Cc: linux-efi

On Wed, 11 Sep 2019 at 21:48, Scott Talbert <swt@techie.net> wrote:
>
> Hi,
>
> I just recently discovered a boot regression that occurred starting in 4.8
> on a Mac Pro Mid-2012 server (MacPro5,1).  Yes, I realize this problem is
> over 3 years old.  Obviously, I haven't been using Linux on this hardware
> in a while.  :-)  I bisected the regression to
> 475fb4e8b2f4444d1d7b406ff3a7d21bc89a1e6f "efi / ACPI: load SSTDs from EFI
> variables".  And indeed, v5.3-rc7 will boot if I comment out the
> efivar_ssdt_load() call, as in:
>
> $ git diff
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index ad3b1f4866b3..691a8671a2ba 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -364,8 +364,8 @@ static int __init efisubsys_init(void)
>          if (error)
>                  goto err_put;
>
> -       if (efi_enabled(EFI_RUNTIME_SERVICES))
> -               efivar_ssdt_load();
> +       //if (efi_enabled(EFI_RUNTIME_SERVICES))
> +       //      efivar_ssdt_load();
>
>          error = sysfs_create_group(efi_kobj, &efi_subsys_attr_group);
>          if (error) {
>
>
> Any thoughts on how to fix this?
>

Thanks for the report. It appears the SSDT loading code is slightly
broken, in the sense that it always iterates over all EFI variables
regardless of whether an SSDT override was actually requested on the
command line, which is silly.

I'll have a patch out shortly, and I'll put you on cc. Please test it
and report back.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 20:42 Boot regression in 4.8 for Mac Pro server Scott Talbert
2019-09-11 23:17 ` Ard Biesheuvel

Linux-EFI Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-efi/0 linux-efi/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-efi linux-efi/ https://lore.kernel.org/linux-efi \
		linux-efi@vger.kernel.org linux-efi@archiver.kernel.org
	public-inbox-index linux-efi


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-efi


AGPL code for this site: git clone https://public-inbox.org/ public-inbox