From: Mimi Zohar <zohar@linux.ibm.com>
To: Lenny Szubowicz <lszubowi@redhat.com>, Ard Biesheuvel <ardb@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-efi <linux-efi@vger.kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-security-module@vger.kernel.org, andy.shevchenko@gmail.com,
James Morris <jmorris@namei.org>,
serge@hallyn.com, Kees Cook <keescook@chromium.org>,
Borislav Petkov <bp@alien8.de>, Peter Jones <pjones@redhat.com>,
David Howells <dhowells@redhat.com>,
prarit@redhat.com
Subject: Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine
Date: Fri, 11 Sep 2020 11:59:07 -0400 [thread overview]
Message-ID: <cb8b4ebaa35d79eba65b011d042d20a991adf540.camel@linux.ibm.com> (raw)
In-Reply-To: <f0a079b1-5f02-8618-fdfe-aea2278113c9@redhat.com>
On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote:
> On 9/11/20 11:02 AM, Ard Biesheuvel wrote:
> > On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz <lszubowi@redhat.com> wrote:
> >>
> >> Move the loading of certs from the UEFI MokListRT into a separate
> >> routine to facilitate additional MokList functionality.
> >>
> >> There is no visible functional change as a result of this patch.
> >> Although the UEFI dbx certs are now loaded before the MokList certs,
> >> they are loaded onto different key rings. So the order of the keys
> >> on their respective key rings is the same.
> >>
> >> Signed-off-by: Lenny Szubowicz <lszubowi@redhat.com>
> >
> > Why did you drop Mimi's reviewed-by from this patch?
>
> It was not intentional. I was just not aware that I needed to propagate
> Mimi Zohar's reviewed-by from V1 of the patch to V2.
>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
> V2 includes changes in that patch to incorporate suggestions from
> Andy Shevchenko. My assumption was that the maintainer would
> gather up the reviewed-by and add any signed-off-by as appropriate,
> but it sounds like my assumption was incorrect. In retrospect, I
> could see that having the maintainer dig through prior versions
> of a patch set for prior reviewed-by tags could be burdensome.
As much as possible moving code should be done without making changes,
simpler for code review. Then as a separate patch you make changes.
That way you could also have retained my Reviewed-by.
Mimi
>
> Advice on the expected handling of this would be appreciated.
next prev parent reply other threads:[~2020-09-11 16:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-05 1:31 [PATCH V2 0/3] integrity: Load certs from EFI MOK config table Lenny Szubowicz
2020-09-05 1:31 ` [PATCH V2 1/3] efi: Support for MOK variable " Lenny Szubowicz
2020-09-21 16:18 ` Arvind Sankar
2020-09-21 16:27 ` Ard Biesheuvel
2020-09-21 16:55 ` Arvind Sankar
2020-09-24 19:09 ` Lenny Szubowicz
2020-10-01 17:44 ` Nathan Chancellor
2020-10-01 20:57 ` Ard Biesheuvel
2020-10-01 21:07 ` Nathan Chancellor
2020-09-05 1:31 ` [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine Lenny Szubowicz
2020-09-11 15:02 ` Ard Biesheuvel
2020-09-11 15:54 ` Lenny Szubowicz
2020-09-11 15:59 ` Mimi Zohar [this message]
2020-09-11 17:18 ` Lenny Szubowicz
2020-09-11 18:16 ` Ard Biesheuvel
2020-09-11 19:08 ` Mimi Zohar
2020-09-11 19:46 ` Lenny Szubowicz
2020-09-05 1:31 ` [PATCH V2 3/3] integrity: Load certs from the EFI MOK config table Lenny Szubowicz
2020-09-11 15:17 ` [PATCH V2 0/3] integrity: Load certs from " Ard Biesheuvel
2020-09-11 16:01 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb8b4ebaa35d79eba65b011d042d20a991adf540.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=andy.shevchenko@gmail.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lszubowi@redhat.com \
--cc=pjones@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).